To: balagi@justmail.de
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       "Greg KH" <greg@kroah.com>, torvalds@osdl.org, alan@redhat.com
Subject: Re: [PATCH 2.6.18] pktcdvd driver module: added sysfs interface
References: <op.tgd9kamfiudtyh@master> <op.tgqhg1pgiudtyh@master>
From: Peter Osterlund <petero2@telia.com>
Date: 01 Oct 2006 14:47:58 +0200
In-Reply-To: <op.tgqhg1pgiudtyh@master>
Message-ID: <m3d59ci4n5.fsf@telia.com>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1228
Lines: 28

"Thomas Maier" <balagi@justmail.de> writes:

> this is a patch for the packet writing module pktcdvd.
> The patch adds a sysfs and a debugfs interface, a Kconfig
> parameter to switch of the procfs interface off and a
> bio write queue congestion handling for the driver.

I think most of these changes are good. However, some comments:

* There are many logically independent parts in this change, so they
  should be in separate patches. For example:
  - Introduce the DRIVER_NAME #define.
  - Add sysfs support.
  - Make procfs support optional.
  - Implement congestion control.
  - Move lots of functions around. (Is it needed at all?)

* You need to add Signed-off-by.

* You should CC Andrew Morton and not Linus. These changes should live
  in -mm for a while before going into the main tree.

* The patch is white space damaged. All lines that should start with a
  single space start with two spaces.

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/