Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Mar 2021 10:35:04 +0200
From:   Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To:     quanyang.wang@windriver.com
Cc:     Rob Herring <robh+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Krzysztof Kozlowski <krzk@kernel.org>,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
Message-ID: <YEXhuGeMoXbfWI6I@pendragon.ideasonboard.com>
References: <20210308070843.2096992-1-quanyang.wang@windriver.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210308070843.2096992-1-quanyang.wang@windriver.com>
Precedence: bulk

Hi Quanyang,

Thank you for the patch.

On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
> 
> The function of_i2c_get_board_info will call of_modalias_node to check
> if a device_node contains "compatible" string. So let's assign the
> proper string "silabs,si5328" to clock-generator@69's compatible
> property to eliminate the error info as below:

As far as I can tell, "silabs,si5328" isn't documented in
Documentation/devicetree/bindings/. We need DT bindings before making
use of the compatible string.

> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> 
> Fixes: 82a7ebf00224 ("arm64: dts: zynqmp: Add DT description for si5328 for zcu102/zcu106")
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts | 1 +
>  arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 12e8bd48dc8c..a73841ad24ce 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -590,6 +590,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				#clock-cells = <1>;
> +				compatible = "silabs,si5328";
>  				clocks = <&refhdmi>;
>  				clock-names = "xtal";
>  				clock-output-names = "si5328";
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 18771e868399..24ce64364d63 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -591,6 +591,7 @@ si5328: clock-generator@69 {/* SI5328 - u20 */
>  				#address-cells = <1>;
>  				#size-cells = <0>;
>  				#clock-cells = <1>;
> +				compatible = "silabs,si5328";
>  				clocks = <&refhdmi>;
>  				clock-names = "xtal";
>  				clock-output-names = "si5328";

-- 
Regards,

Laurent Pinchart