Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1629722pxb; Mon, 8 Mar 2021 02:21:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyRMrblyu2Hz3fOvjC1meFwzF9EKE5utA+tI7/cIXqrGLPJi0jbI9nd+ra6vceFTND2ON8m X-Received: by 2002:a17:906:1746:: with SMTP id d6mr14752736eje.36.1615198905119; Mon, 08 Mar 2021 02:21:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615198905; cv=none; d=google.com; s=arc-20160816; b=YYZVp7xzJJ6fD8g/ebjThzdI+knJ4yNWAkSo0S1Xu6Yg+bZPZZcOIws0xgjsp+XPVJ F9CE6IioMFLIRRln131K8SAJRxmCa74jzs1gIww5mStP0tFQN+ezPQTNAF6KMvXeFHh5 tJ+ICoRh1WsAbQiGwjQrt/dfKXL30C16KFKKYMWSHQwSG9iZXHGFBSn265n4oqVihblr P3/t445jy4wnR+KGXfdbsWtHHcaF0Xd1P2SEM8hZEUXxW/nC9pYlv2HOizsvRFH2FwkJ QbZ55SCYuiYC3pwevg3tSvYwqrFGUIL2GPQqTomsswKl+q7D4PZHwo5ZfOnRD2eGy/ZO 4nJg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:message-id:in-reply-to:subject:cc:to:from :date:dkim-signature; bh=WV5LbrdHcaxljEGkYqcfAnmekrDfv3zHi2HXiGUxpB8=; b=fijrSB7gjkwMfzSxANk8pLMajWWaDaZRVCP9DfY8BPx5WXzXFN4eq9RApJmMNT4JTM WsvLJarLuKBsNIwEtevgUeGCpTRpUdW9WC/4a/mGiKfyeO/s/6HmiAvG9MFueGnKr/KK d8tuSHvliXc8wfaEcZ5iss6Oq9ts6H2/XYUweJ12MDyj1/ZVl5WvYT5iNTGO2e0hjq0W s5+7foC4qoOp8F3zvTPgvZYB4+v8mTUjU/TOfbVSzmeOnXPEDMPtBUE0IKsCaihO+T9P Uat9WNDdqiaBkNWAa/vqvqdQ0eKG/4fjf3zAgAQlQVQESXLajBaFtVtPyJ4kufw8WmWM nkbg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sox73Kmx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m26si7027151edv.514.2021.03.08.02.21.22; Mon, 08 Mar 2021 02:21:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Sox73Kmx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231664AbhCHKIS (ORCPT + 99 others); Mon, 8 Mar 2021 05:08:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:59250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231610AbhCHKHs (ORCPT ); Mon, 8 Mar 2021 05:07:48 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D891A64DE5; Mon, 8 Mar 2021 10:07:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615198068; bh=1l+pOChyWmagC/15Du+ORFDSdCjmKOpaMI4gbleHh2U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=Sox73KmxMnQGtEbF7X4HAkaa1D1hRHQNyi+ueb30tu1WvXyRJw/J5xukZWaob4HPi VmeO+056cNvGnyqUnKM962UEipgfz3hD/n8MHb6CWtAs53e/7BDyzKEHLtDU+Liqb6 KkWIGQnFzinet4zl3SsYSBNXPWLGH9is+ZKABTuURS592Vl042fVi4+55jOIWGIpoJ 401zVr20PcNaRyC/beHLtZGVsOLq4zAlblLgu1meOQ6c+Vn3xolXcD8UEmgGPb/5HN M7AmVMgr0JOdfl08muLSLYWVPShMA6e6WdUA2U80daaROGPMZJ7k0hKzU4d7zh3AqZ M7Rp3MU94N/mg== Date: Mon, 8 Mar 2021 11:07:44 +0100 (CET) From: Jiri Kosina To: =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= cc: Srinivas Pandruvada , Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition In-Reply-To: <20210206151348.14530-1-uwe@kleine-koenig.org> Message-ID: References: <20210206151348.14530-1-uwe@kleine-koenig.org> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 6 Feb 2021, Uwe Kleine-König wrote: > A remove callback is only ever called for a bound device. So there is no > need to check for device or driver being NULL. Srinivas, any objections to this patchset? The cleanups look good to me. Thanks, -- Jiri Kosina SUSE Labs