Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751111AbWJAPhz (ORCPT ); Sun, 1 Oct 2006 11:37:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751127AbWJAPhz (ORCPT ); Sun, 1 Oct 2006 11:37:55 -0400 Received: from havoc.gtf.org ([69.61.125.42]:28139 "EHLO havoc.gtf.org") by vger.kernel.org with ESMTP id S1751111AbWJAPhy (ORCPT ); Sun, 1 Oct 2006 11:37:54 -0400 Date: Sun, 1 Oct 2006 11:37:53 -0400 From: Jeff Garzik To: mhw@wittsend.com, Andrew Morton , LKML Subject: [PATCH] drivers/char/ip2: kill unused code, label Message-ID: <20061001153753.GA5388@havoc.gtf.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 30 Kill warning: drivers/char/ip2/ip2main.c: In function ‘ip2_loadmain’: drivers/char/ip2/ip2main.c:782: warning: label ‘out_class’ defined but not used This driver's initialization (and cleanup of errors during init) is extremely convoluted, and could stand to be transformed into the standard unwinding-goto style of error cleanup. Signed-off-by: Jeff Garzik diff --git a/drivers/char/ip2/ip2main.c b/drivers/char/ip2/ip2main.c index 331f447..bcf6573 100644 --- a/drivers/char/ip2/ip2main.c +++ b/drivers/char/ip2/ip2main.c @@ -779,8 +779,6 @@ retry: ip2trace (ITRC_NO_PORT, ITRC_INIT, ITRC_RETURN, 0 ); goto out; -out_class: - class_destroy(ip2_class); out_chrdev: unregister_chrdev(IP2_IPL_MAJOR, "ip2"); out: - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/