Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v5 1/4] PM / devfreq: Register devfreq as a cooling device
 on demand
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     cwchoi00@gmail.com, linux-kernel@vger.kernel.org,
        linux-pm@vger.kernel.org, steven.price@arm.com,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Chanwoo Choi <cw00.choi@samsung.com>
References: <20210308091646.28096-1-daniel.lezcano@linaro.org>
 <c6d6781a-759c-0361-aaaa-28a625e4809b@arm.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
Message-ID: <bd6c8e7f-e626-b6f4-65b9-f7ea96098677@linaro.org>
Date:   Mon, 8 Mar 2021 13:00:21 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <c6d6781a-759c-0361-aaaa-28a625e4809b@arm.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 08/03/2021 10:53, Lukasz Luba wrote:
> Hi Daniel,
> 
> In general the approach is good. If there is a special GPU driver, which
> would like to provide 'struct devfreq_cooling_power *' it would leave
> 'is_cooling_device=false' and register manually:
> devfreq_cooling_em_register(df, dfc_power);
> 
> Please find only a few minor comments below.
> 
> 
> On 3/8/21 9:16 AM, Daniel Lezcano wrote:
>> Currently the default behavior is to manually having the devfreq
>> backend to register themselves as a devfreq cooling device.
>>
>> Instead of adding the code in the drivers for the thermal cooling
>> device registering, let's provide a flag in the devfreq's profile to
>> tell the common devfreq code to register the newly created devfreq as
>> a cooling device.
>>
>> Suggested-by: Chanwoo Choi <cwchoi00@gmail.com>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>> ---

[ ... ]

>> +    struct thermal_cooling_device *cdev;
> 
> The linux/thermal.h for 'cdev' would be needed in this header.

May be just a forward declaration ?

struct thermal_cooling_device;

>> +
>>       struct notifier_block nb_min;
>>       struct notifier_block nb_max;
>>   };
>>
> 
> With this small changes:
> 
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
> 
> Regards,
> Lukasz


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog