Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1710550pxb; Mon, 8 Mar 2021 04:38:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJxs+PnFrL+98xMLb8bvHzP5AgQYj5DPb2DEjgrKDtrOfyDU+yMxpD44giX1zRwDCYPjb3S1 X-Received: by 2002:a17:906:3552:: with SMTP id s18mr14964922eja.497.1615207105558; Mon, 08 Mar 2021 04:38:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615207105; cv=none; d=google.com; s=arc-20160816; b=ceDa68j1okwbbNiVvm07a+vxqQDD1tnXUN7w7lfBbChf8q1/samZeqPWsmIAzuz+6+ CJGSX8dBYJD32Tvw0AdUevbjwndSVG+CT565Kli8eLUnJGGB6nhziLOlD3siEARUAG2J WYnihXgkpBeTQdi+XF/dH2JAjeuyHJCnYhCa4LAl/iHHu0V0zmGb4/mWQdH3D1SYh56C nykoTxxdTncrO9mfWYOPx1I9+YqowPB3kIdRvZXLJiZ2uSoph5PTC7mc0NFalkiGlOBT Ht2G/wyc41ytiwQmO2gP1Z5nYffcs41BwZQhnYPTD/hoUnQKvhierzKGqqA8ZSWY45dR vFXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/03+xGs1mC4WlTM/0k72cxAuxKX2yysq0JCMk3e1fAI=; b=S4Yg0K0MNP5dN6Uqvlia6GeAma5RiTgJmkbFZmUn/OSz0hU5XvTz0esfkfIHivzm/5 cDjor+4zIoYUnfk0PY5b3P1vnKRHtljS30vHRqzUfVghLaCWJGzSmzFVxCwg3/Dx/ouZ lIWBw/IvwYI4nqm+QEecoLIcmHYAfntaqTxZ1EM1kDqsJh0XhwzwfRX0D+WbVosMBEN2 ZmKj+0sGYb0Lamx/C1Uasu+Z+rjDBRNiUhSKWOtdFwpt9F8Pb3P9Lj7D4uQSyuqhpo/u 4u3SX6SSMHNFS5zsZKSkZrjkvOmKfJyN4C0DZp8VzWA4t9VHWanpvfABTK8ynUjic1A1 NI9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="MvbOa/uw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w2si7118983ejv.120.2021.03.08.04.38.03; Mon, 08 Mar 2021 04:38:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="MvbOa/uw"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229899AbhCHMe4 (ORCPT + 99 others); Mon, 8 Mar 2021 07:34:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:43366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbhCHMeZ (ORCPT ); Mon, 8 Mar 2021 07:34:25 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id AB67A651CF; Mon, 8 Mar 2021 12:34:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615206865; bh=X1ZoBNwxa/MboWgbPk8CHKPA5D7S7dqWy2Ij/5pRykw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MvbOa/uwZXaCcF0UBKxoIAzUM16Adg0FyUpGNwhMn8fmt8s5JRe2GRzmEr3GG38WQ ieNIevEPIb9fwCqlIB4KnXAghQeILOcL43L7XR4DzA9sj3m6v3AYeNDNNwO79MZmY0 Bk2iv2RISlw7G3MNj4oRBksmhmZWKkqIFl7btgq8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Braha , Jason Gunthorpe , Sasha Levin Subject: [PATCH 5.10 33/42] RDMA/rxe: Fix missing kconfig dependency on CRYPTO Date: Mon, 8 Mar 2021 13:30:59 +0100 Message-Id: <20210308122719.747627284@linuxfoundation.org> X-Mailer: git-send-email 2.30.1 In-Reply-To: <20210308122718.120213856@linuxfoundation.org> References: <20210308122718.120213856@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Julian Braha [ Upstream commit 475f23b8c66d2892ad6acbf90ed757cafab13de7 ] When RDMA_RXE is enabled and CRYPTO is disabled, Kbuild gives the following warning: WARNING: unmet direct dependencies detected for CRYPTO_CRC32 Depends on [n]: CRYPTO [=n] Selected by [y]: - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y] This is because RDMA_RXE selects CRYPTO_CRC32, without depending on or selecting CRYPTO, despite that config option being subordinate to CRYPTO. Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible") Signed-off-by: Julian Braha Link: https://lore.kernel.org/r/21525878.NYvzQUHefP@ubuntu-mate-laptop Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/sw/rxe/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/sw/rxe/Kconfig b/drivers/infiniband/sw/rxe/Kconfig index 452149066792..06b8dc5093f7 100644 --- a/drivers/infiniband/sw/rxe/Kconfig +++ b/drivers/infiniband/sw/rxe/Kconfig @@ -4,6 +4,7 @@ config RDMA_RXE depends on INET && PCI && INFINIBAND depends on INFINIBAND_VIRT_DMA select NET_UDP_TUNNEL + select CRYPTO select CRYPTO_CRC32 help This driver implements the InfiniBand RDMA transport over -- 2.30.1