Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Mar 2021 14:57:27 +0100 (CET)
From:   Jiri Kosina <jikos@kernel.org>
To:     Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
cc:     benjamin.tissoires@redhat.com, rydberg@bitmath.org,
        linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: wacom: Assign boolean values to a bool variable
In-Reply-To: <1611128070-59752-1-git-send-email-abaci-bugfix@linux.alibaba.com>
Message-ID: <nycvar.YFH.7.76.2103081457220.12405@cbobk.fhfr.pm>
References: <1611128070-59752-1-git-send-email-abaci-bugfix@linux.alibaba.com>
User-Agent: Alpine 2.21 (LSU 202 2017-01-01)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Wed, 20 Jan 2021, Jiapeng Zhong wrote:

> Fix the following coccicheck warnings:
> 
> ./drivers/hid/wacom_wac.c:2536:2-6: WARNING: Assignment of
> 0/1 to bool variable.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
> ---
>  drivers/hid/wacom_wac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
> index 1bd0eb7..62b0f71 100644
> --- a/drivers/hid/wacom_wac.c
> +++ b/drivers/hid/wacom_wac.c
> @@ -2533,7 +2533,7 @@ static void wacom_wac_finger_slot(struct wacom_wac *wacom_wac,
>  	    !wacom_wac->shared->is_touch_on) {
>  		if (!wacom_wac->shared->touch_down)
>  			return;
> -		prox = 0;
> +		prox = false;
>  	}

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs