Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1851369pxb; Mon, 8 Mar 2021 07:53:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3wA+jzPePIKDDYj2TDebmbxKMvGwY8GBpbPV144qh5XSHiPCss0ABnA+z71EDfEADhPql X-Received: by 2002:a17:906:b102:: with SMTP id u2mr15571445ejy.303.1615218798201; Mon, 08 Mar 2021 07:53:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615218798; cv=none; d=google.com; s=arc-20160816; b=eGUSJh71rMku+eTgLad2RSpI3KnE0ROx+bCXz1GkZ6eVWaCUX1eDmvMIKyTkpk97HM T4BXm+z16/qnhHELSAyGc/yVJsSKageE/0842AQQo9YP7MMslNgAgNn82H+NqTNu+JpD OSOUU53qFLh+pyEbFuTfbZu4mXK3uVr0KLnMfZnfMe7pF2mctfzPCOPfMdJGiauMgWcX jX6X5QjffSsc4caBz2HJMv0e1nkeohT4hQAD1ESv4/rUracF9O2aiFMkZ4VSLO4WO34S RWW/LQfHzA58LPmCUQaOf+WdVKCqAZxVeOkWdTepdq3ntq/BCBp9e1d5teo4eeg+d6VU Q+/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:user-agent:date :mime-version:references:in-reply-to:cc:to:reply-to:from:subject :message-id; bh=UrJzfLcCnxaOoFMAc3IPMH6xpm/uARcRnsEzoAN4jHA=; b=zM0vnQxbF/B36+GN3T7+MqWGFUkB5y7Tdva9cUUT7eOnFkprr/VUB0VzNTAf6jlpGF 7LdhwAR0XhETf4ghbWBgkg2IsTo1q2jCbo+pKTV4+G9B49/Sc6LbWUk08xhy7HZjMBGn wG1d4f5g7zxRKlSIGtj3Hdbd6Q2iSvjC0pyMZsdC9uOO06/3bvEMxtWce7GLVcC+Wnzs 8aFwCAnBZR6fjY6XogCfvg1t86upKZKfYVTp7zKcAse/ccvgBbbWq7ttzt+HfNZgC2NX G3Ulf9f8lxr5b7Qfb3XuNt9io1dnvBXWCUps9ta3/AeCH+wm+zYGJGVJXH4ZBfR/DQO5 73hA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m12si7255790ejx.720.2021.03.08.07.52.54; Mon, 08 Mar 2021 07:53:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229646AbhCHPvZ (ORCPT + 99 others); Mon, 8 Mar 2021 10:51:25 -0500 Received: from mail-lf1-f43.google.com ([209.85.167.43]:42543 "EHLO mail-lf1-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbhCHPvB (ORCPT ); Mon, 8 Mar 2021 10:51:01 -0500 Received: by mail-lf1-f43.google.com with SMTP id v2so8728764lft.9; Mon, 08 Mar 2021 07:51:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:reply-to:to:cc :in-reply-to:references:mime-version:date:user-agent :content-transfer-encoding; bh=UrJzfLcCnxaOoFMAc3IPMH6xpm/uARcRnsEzoAN4jHA=; b=Dx0fTIdrXjLLrEGzfmiiXzJ+AHjtlJZbmq/jml6KCXdVXowmz2/o/9HzP58JrgjO7O 7w5Tup7PrG4Rr2lGmMjnWekTcj3ncZ4Ok1kBkmShOvcl+FeLXZk5tfWjKYSmbe1xYXJo ISapw9SSIT60+ZwKVxxFEh3C8PUBuh6X9HmThYh+ePcPsKp4D8MREisX9xxPfoAGBvvf Jvy1a5EgjHDy9RU4Vzde6PHw6s5KjP0mvAskhHQ+b4yvVfWFJOLtXLqf1Ftqivlpci7I QdgA/Pq4UO9OANHMj+81W9bD9zASO668rErw9quiDKt6rw1d5VfobeU3+hD9BOJ+Jgnu nLyg== X-Gm-Message-State: AOAM532EdjZxS9gpO43Ti97kLON6Abp1X3RyorvfbeOIojmxTXgrNhWm oPb/gwcVgn8gyY6RcK2txAw= X-Received: by 2002:a19:d61a:: with SMTP id n26mr14346288lfg.383.1615218660426; Mon, 08 Mar 2021 07:51:00 -0800 (PST) Received: from dc7vkhyyyyyyyyyyyyycy-3.rev.dnainternet.fi (dc7vkhyyyyyyyyyyyyycy-3.rev.dnainternet.fi. [2001:14ba:16e2:8300::4]) by smtp.gmail.com with ESMTPSA id o11sm1388325lfu.157.2021.03.08.07.50.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 07:51:00 -0800 (PST) Message-ID: <7ca68ba756672ab937550f6ffd2b07dbd1b021d1.camel@fi.rohmeurope.com> Subject: Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional From: Matti Vaittinen Reply-To: matti.vaittinen@fi.rohmeurope.com To: Arnd Bergmann , Sebastian Reichel , Timon Baetz , Krzysztof Kozlowski Cc: Arnd Bergmann , Andy Shevchenko , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20210308152935.2263935-1-arnd@kernel.org> References: <20210308152935.2263935-1-arnd@kernel.org> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Date: Mon, 08 Mar 2021 17:50:54 +0200 User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Arnd, On Mon, 2021-03-08 at 16:29 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > I assume there is no reason to actually build this driver without > extcon > support, so a hard dependency is the easiest fix. Alternatively the > header file could be extended to provide additional inline stubs. I am absolutely not insisting this but it would be better if there was no hard dependency. I've tried couple of times to do changes to bunch of drivers (added some devm-functionality or generic definitions or - you name it) and I always end up at least compile-testing changes to multiple drivers. I always repeat following: 1. Manually hack the Makefiles to compile changed drivers as modules 2. Try CONFIG_COMPLILE_TEST - unfortunately not too widely supported 3. Manually hack more to get drivers with 'hard dependencies' compiled - occasionally ending up to commenting out the calls with dependencies. So, if adding the stub is straightforward I'd vote for it. But I guess you know this quite well so I am just giving my 10 cents - decision can be yours :) Best Regards Matti Vaittinen -- Matti Vaittinen, Linux device drivers ROHM Semiconductors, Finland SWDC Kiviharjunlenkki 1E 90220 OULU FINLAND ~~~ "I don't think so," said Rene Descartes. Just then he vanished ~~~ Simon says - in Latin please. "non cogito me" dixit Rene Descarte, deinde evanescavit (Thanks for the translation Simon)