Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: qGAn2jkSazw168RkMm0T9BZb9nvVxoDZtLKzoTAi1+duqCYyWBhOn5cjAHh0R6fIO6lWC8BaiL
 mp9sR3r+s6oQ==
IronPort-SDR: B1b74B1yMTqj5Dr9tfyahDvUZ/aOJ8ccU+6DLUh9DF44qFfPJ32yU3L4nggjd+ZOlDxLl1z4vw
 OQeEo+8PkVsA==
Message-ID: <00ad0906b90a290e9737b7bf7d8c5ab9c6ed61e6.camel@linux.intel.com>
Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state
 bit during suspend/resume
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     Jiri Kosina <jikos@kernel.org>, Ye Xiang <xiang.ye@intel.com>
Cc:     jic23@kernel.org, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 08 Mar 2021 08:00:41 -0800
In-Reply-To: <nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm>
References: <20210303062825.7724-1-xiang.ye@intel.com>
         <nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote:
> On Wed, 3 Mar 2021, Ye Xiang wrote:
> 
> > ISH firmware uses connected standby state bit
> > (CONNECTED_STANDBY_STATE_BIT bit 1)
> > to notify current power state to sensors instead of suspend state
> > bit (bit 0).
> > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to
> > firmware
> > to be compatible with the previous version.
> 
> Could you please make the changelog more verbose -- namely what 
> user-visible issue this is fixing?
Xiang,

I think this change is for related to Elkhart Lake for support of
connected standby (keep listening for sensor events during Linux
suspend for some sensors). In this way some sensor can wake up the
system.

Thanks,
Srinivas


> 
> Thanks.
>