Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1861309pxb; Mon, 8 Mar 2021 08:06:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJzf547ndP+X90ouVSkjQsRROmSwWhTSfT9Dk1edBCc4e/fhzjdW1EG6LqwEvISQy8ZJlfnk X-Received: by 2002:a05:6402:1649:: with SMTP id s9mr22655810edx.177.1615219590730; Mon, 08 Mar 2021 08:06:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615219590; cv=none; d=google.com; s=arc-20160816; b=osGRpt1rs+MAfsHqguYJyK94tnwk9NzgPGvETGejnnuQfMhtaiRYGLMricvHmeKRYh /RQgGeXqzldtiS0j+bawzIMRl0BQGvBytaOx1g6LLHxOurkzQMhild42aVKyv2vEhrXU 1cSBKonQpYd95h3sfK6X7LBCi/KRJpmnODuWi1tKImteUL+6ME1Zyo4EezSLiYJxVxgD k+Vg0tViu22lc0iFknGBfN3EpQRKeFsm14mFNbQy6hc2bpsKjIZ3DiCVyfT1deRpg6fW fCUje2p0iPD5Yjz8W4wpatVe51t57IlRSKmlG11m7b9mukg2mDS3w44Vjp4cyFTccB5p rEMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:ironport-sdr:ironport-sdr; bh=x6bjvECFU8RO5S1RfYBaTF9BWqbaGeFymSYt2SvoSuc=; b=EAcrlEUhf+c3bqs47lgLeS2GlwdzwaZoYpAt1AAz0dhjFsQx+JEjx2FSmPTLQN/pS6 3YQeS/0m7nzcg5+4Y1fm9Jm5IiOj6xiE1adQcYbdCrp1o4qwUBHpeW2PxLLYrkHGwdAP xroLgqiyWJ64pm0Bn/mmtwe7HXHz+dMHJdavYwLbUOmaJXuUDw5ZJ8D2rId3w3gI79F8 3t+mgnF1IgDxmyn5mLjbE1aIsLHjJvO5uQb3UynQ+IWrzQvOsxawh+SELkiOq+LoQWrU COsLbLBMaJS299sFy5JZaIROLF/7L6i2xnG46fLIgw6Z2rFfHhcp/yzB0Q0zPKpTQ1vD lVSg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a20si8082735eda.157.2021.03.08.08.05.43; Mon, 08 Mar 2021 08:06:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhCHQEQ (ORCPT + 99 others); Mon, 8 Mar 2021 11:04:16 -0500 Received: from mga14.intel.com ([192.55.52.115]:16665 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230200AbhCHQEE (ORCPT ); Mon, 8 Mar 2021 11:04:04 -0500 IronPort-SDR: AnMju5dDiFZXcLyIPB/Y7tMn/8OTRnMtADhh6yBu1ynM+SqBI8hoGdeBgQbIB3Iz1S0JCy4Qiz sd5UrQ9BVbyw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="187417777" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="187417777" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:04:03 -0800 IronPort-SDR: oArg1YrvPkI/vKbk+xDakXU2Chg+VproKHC99GVZyEv8tK9wp+Rs+d1CKXUVeDrF2vkrBA1aBL HAMj/zUlf68Q== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="385895120" Received: from arohrbax-mobl.amr.corp.intel.com ([10.209.91.130]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:03:49 -0800 Message-ID: <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition From: Srinivas Pandruvada To: Jiri Kosina , Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= Cc: Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 08 Mar 2021 08:03:49 -0800 In-Reply-To: References: <20210206151348.14530-1-uwe@kleine-koenig.org> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-03-08 at 11:07 +0100, Jiri Kosina wrote: > On Sat, 6 Feb 2021, Uwe Kleine-König wrote: > > > A remove callback is only ever called for a bound device. So there > > is no > > need to check for device or driver being NULL. > > Srinivas, any objections to this patchset? The cleanups look good to > me. Sorry, I missed this series. No objection for taking these patches. Thanks, Srinivas > Thanks, >