Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1866437pxb; Mon, 8 Mar 2021 08:12:48 -0800 (PST) X-Google-Smtp-Source: ABdhPJwWHZDW131UIONrTzIbNLdBqJ4mmZ16iV/3lY6HTlnQanRntf492nXFcyTbw7bFAn8rORUx X-Received: by 2002:a50:9d8a:: with SMTP id w10mr22698902ede.39.1615219968091; Mon, 08 Mar 2021 08:12:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615219968; cv=none; d=google.com; s=arc-20160816; b=qE5CIwn99Cyel+JJO58pAq4pYK01mOmNZT/MRl4CHIUqueLlYGjcgtw3Dngc9njMN1 gVditqN16ZuJq6rwc+Eqpen5lkLzzphO6CdE8oIcpimlySc34QLEF8zBf77JCrX2mAsr Jl6P/erASVrQearj/H7CbfpDxeOZWYnMuTJcwMlGxFGXvF9Lr46FjZsZlRa04EjavsdP cfFPt4/k2VqbfFyzCsuxTQ1ZouEpIEMtRaACOC9l4xy0zSJrFnSLWVtnSVExotcSOWQ5 iuDecK6WbUBi2eSOoMjwleweszsIxVt77SD+qtZaaVixJ2Wuqyj102QCRdNrX0ZRQf8w 9M2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:ironport-sdr:ironport-sdr; bh=ZmJLSTY4UwA14eOnzYdckaqtddXfmfRSIRx8U/cbr1k=; b=loHpbNuX2SuJK9dr+dnjuVPtd5URM6JCcTjYF44meDkF0IxuHQibncPRe9a1jreERN nk7/nN63iE4aIPtCmRmnJoXh2ai5gIM8V4E64n3oA+Ja2rehHPHKA6HcdLbp2r+xNjSi hs75tBqhb4/crLrlOy88Y14clLZHHHbQDOGvhSfW3SjybIiarwoxRYmsr1zveveRkk0+ gDiCU2tBmO2HBmG1ZqGK+xKmnSjzucAS65+AgtzwaPNvbx+Mr/+F0IoGUXoy6sQRGdQj ODZmjYhsqP+jd8KdDC1lVrGr0/Zg2Hoa75tuPSFYs1NKQ2lAYJLg1Et4d7i+WxMuqWpP lJ2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg1si6996120edb.610.2021.03.08.08.12.24; Mon, 08 Mar 2021 08:12:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbhCHQJQ (ORCPT + 99 others); Mon, 8 Mar 2021 11:09:16 -0500 Received: from mga18.intel.com ([134.134.136.126]:55326 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231153AbhCHQIp (ORCPT ); Mon, 8 Mar 2021 11:08:45 -0500 IronPort-SDR: w6kFO3aSJ0qkv2B+PrOEyRs75ZMV70AKuyH/1WMVqjmz46EELnh4FIEK9JFfc57dUroGTmzHAC Se0tPlFkokUA== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="175670135" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="175670135" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:08:44 -0800 IronPort-SDR: OUFns45em4p49P9cokLZVeZftZt4yYCXzvn+ScjFMwJ2vbU82i/VINKStc7FNnQrtAynkOXpRR 2HeshybNmQOw== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="430419069" Received: from dbdavenp-mobl1.amr.corp.intel.com (HELO [10.212.234.206]) ([10.212.234.206]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:08:41 -0800 Subject: Re: [PATCH v4 1/2] platform/x86: dell-privacy: Add support for Dell hardware privacy To: "Yuan, Perry" , "pobrn@protonmail.com" , "oder_chiou@realtek.com" , "perex@perex.cz" , "tiwai@suse.com" , "hdegoede@redhat.com" , "mgross@linux.intel.com" , "Limonciello, Mario" Cc: "platform-driver-x86@vger.kernel.org" , "alsa-devel@alsa-project.org" , "broonie@kernel.org" , "lgirdwood@gmail.com" , "linux-kernel@vger.kernel.org" References: <20210301093753.16300-1-Perry_Yuan@Dell.com> <551e30d2-0211-f3cb-fbb8-ee5b2f22a851@linux.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 8 Mar 2021 09:59:15 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>> module_param(force_rfkill, bool, 0444); >>> MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted >>> models"); >>> >>> + >> >> spurious line change > I just want to make them separate with more space . > If it cause concern, I will remote the line in V5. it's fine to improve spaces/alignment, just do it in a separate patch. > >> >>> static const struct dmi_system_id dell_device_table[] __initconst = { >>> { >>> .ident = "Dell laptop", >>> @@ -2205,11 +2209,17 @@ static int __init dell_init(void) >>> dell_laptop_register_notifier(&dell_laptop_notifier); >>> >>> if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) && >>> - dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { >>> - micmute_led_cdev.brightness = >> ledtrig_audio_get(LED_AUDIO_MICMUTE); >>> - ret = led_classdev_register(&platform_device->dev, >> &micmute_led_cdev); >>> - if (ret < 0) >>> - goto fail_led; >>> + >> dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { >> >> not sure why you changed the alignment? > The previous alignment is a little not correct. > So I adjust it > If it cause concern, will restore it to original shape. same here, use a different patch.