Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1871372pxb; Mon, 8 Mar 2021 08:19:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJwZiomiCKqLt3oDntNHlcMpGLNJ+4aUDdrMRopzD5/w84Pl2nLKtRpQnVIsvfYNavycPbx8 X-Received: by 2002:a17:906:2e45:: with SMTP id r5mr13454263eji.380.1615220353340; Mon, 08 Mar 2021 08:19:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615220353; cv=none; d=google.com; s=arc-20160816; b=0S74itDOTmRLp8j0IO8V8lt/so1CcctzLpq7Gq+663bMjyQ9oa6kg1BLENDppxMpyy gyRmVGKU3Lc2jaIMiKvSJLRzaAzl3+HoQeMGDWqmGsxgnGFXccja1o7OLWU35pB47+38 5cfjj3js7s2P4seIvIwYRRZb6530fts4L21B/F94V+zkV+iOFfZ/bCzXpCXsju2+pXzo AOSQSVp1vYf0aALkqx11ZG6fpspgHBgX5h/Kw8Bv8RQdnfGAdH8nTpZoxYH5X6HN1CMa ERrnNnuxPzY+GGG8fH17m4PYpKmCv7cBUUPcGwVRQ97qHvfrwXyVDcDV7k951ole8UjP aJqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent:references:message-id :in-reply-to:subject:cc:to:from:date:dkim-signature; bh=YqfZ8x3X8VXuZOFsc3XTeBnTp8uyN54qf2imr9/r5e0=; b=zYy94gDfbdaeOBy8uiEvq2z88+zFFnpUw3OyPYnFfkHSx7jNlco43wZ1XYqMtlucBw h3Mzdc3LNM43HNbg1/EjfGCPC+aJRnpzevqPwQn4f98K5fNTu9PTAGvLs6XYYNZlKCkz TH976JOTgoC3p8ee0WruyOb550lLtG6w/JYwDld1jb/efqi5NoyZMqyDWQ1l8Me3kDdi 2SoY5KuI/h1aomXfhgiYayWYkqE9PSILTyinjK3rwxNhSeunDwkAgyp1kCjzMoIv9UVt 6s+AikR83/6OvcEHva9bqbWw+aCTu7+Igqk9e/GriButPv++A+3KYX0rIwvqg1CNVr7k 8eJg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=idQje9Be; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dp18si7531532ejc.432.2021.03.08.08.18.47; Mon, 08 Mar 2021 08:19:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=idQje9Be; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbhCHQRL (ORCPT + 99 others); Mon, 8 Mar 2021 11:17:11 -0500 Received: from mail.kernel.org ([198.145.29.99]:43854 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231128AbhCHQQ6 (ORCPT ); Mon, 8 Mar 2021 11:16:58 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 740E56521B; Mon, 8 Mar 2021 16:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615220218; bh=cW8t7xuDTgs4FwnpsppxTtiL2Zc2bKlDJBhJ+T5cif8=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=idQje9Be807E9KD5TrZ2QN5fQpB4W8O/cC7UcgUJR+oTpdJs+kiouq8xbBRKB2eR1 96m122FwGzxie4GwagllIPFZ4s8lFrSAmzyH2IT/IuIVRJbTnKt2/14I6gPXJ3DU1G rym3rO2vWV9ChrPX1UAG+2JOPFQz2VmVGEmoawgN1TANMHp2mXRliZaNx1L0Vywe4d Zf1fo3PMoZkmfRGJYn7xIGdGwCd0mrR0InvKgnOYf1CEcqssbiAl4BjE9R8aCDtiSL nCLHRNcJ/zX6BvmH9fQD2evdAtxuAQVmKogUw/RqB/IVcSZRp0n11r+HLvQXTkJuEI kVuGOXO2TlfcQ== Date: Mon, 8 Mar 2021 17:16:54 +0100 (CET) From: Jiri Kosina To: Srinivas Pandruvada cc: =?ISO-8859-15?Q?Uwe_Kleine-K=F6nig?= , Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition In-Reply-To: <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> Message-ID: References: <20210206151348.14530-1-uwe@kleine-koenig.org> <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 8 Mar 2021, Srinivas Pandruvada wrote: > > > A remove callback is only ever called for a bound device. So there > > > is no > > > need to check for device or driver being NULL. > > > > Srinivas, any objections to this patchset? The cleanups look good to > > me. > Sorry, I missed this series. > No objection for taking these patches. Thanks. Applied with your Acked-by: If you disagree with that interpretation of your statement above, please holler :) Thanks, -- Jiri Kosina SUSE Labs