Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates
 149.199.62.198 as permitted sender) receiver=protection.outlook.com;
 client-ip=149.199.62.198; helo=xsj-pvapexch02.xlnx.xilinx.com;
Envelope-to: linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org,
 devicetree@vger.kernel.org,
 krzk@kernel.org,
 laurent.pinchart@ideasonboard.com,
 robh+dt@kernel.org,
 quanyang.wang@windriver.com
Subject: Re: [PATCH] arm64: dts: zynqmp: Remove si5328 device nodes
To:     <quanyang.wang@windriver.com>, Rob Herring <robh+dt@kernel.org>,
        Michal Simek <michal.simek@xilinx.com>,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>
CC:     Krzysztof Kozlowski <krzk@kernel.org>,
        <devicetree@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
References: <20210308115437.2232847-1-quanyang.wang@windriver.com>
From:   Michal Simek <michal.simek@xilinx.com>
Message-ID: <66e639c2-a1da-8ca5-2031-fe37eb14d740@xilinx.com>
Date:   Mon, 8 Mar 2021 17:27:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <20210308115437.2232847-1-quanyang.wang@windriver.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2021 16:28:01.1250
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b761914-eec4-4d02-2d9e-08d8e24f244a
X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.62.198];Helo=[xsj-pvapexch02.xlnx.xilinx.com]
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT032.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR02MB2895
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 3/8/21 12:54 PM, quanyang.wang@windriver.com wrote:
> From: Quanyang Wang <quanyang.wang@windriver.com>
> 
> The function of_i2c_get_board_info will call of_modalias_node to check
> if a device_node contains "compatible" string. But for the device si5328
> at zcu102/zcu106 boards, there is no proper DT bindings for them. So remove
> si5328 device nodes from dts files to eliminate the error info in the boot
> message:
> 
> i2c i2c-10: of_i2c: modalias failure on /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> i2c i2c-10: Failed to create I2C device for /axi/i2c@ff030000/i2c-mux@74/i2c@4/clock-generator@69
> 
> Signed-off-by: Quanyang Wang <quanyang.wang@windriver.com>
> ---
>  .../boot/dts/xilinx/zynqmp-zcu102-revA.dts    | 20 +------------------
>  .../boot/dts/xilinx/zynqmp-zcu106-revA.dts    | 20 +------------------
>  2 files changed, 2 insertions(+), 38 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> index 12e8bd48dc8c..eca6c2de84a7 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dts
> @@ -580,25 +580,7 @@ i2c@4 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <4>;
> -			si5328: clock-generator@69 {/* SI5328 - u20 */
> -				reg = <0x69>;
> -				/*
> -				 * Chip has interrupt present connected to PL
> -				 * interrupt-parent = <&>;
> -				 * interrupts = <>;
> -				 */
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				#clock-cells = <1>;
> -				clocks = <&refhdmi>;
> -				clock-names = "xtal";
> -				clock-output-names = "si5328";
> -
> -				si5328_clk: clk0@0 {
> -					reg = <0>;
> -					clock-frequency = <27000000>;
> -				};
> -			};
> +			/* SI5328 - u20 */
>  		};
>  		/* 5 - 7 unconnected */
>  	};
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> index 18771e868399..eff7c6447087 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dts
> @@ -581,25 +581,7 @@ i2c@4 {
>  			#address-cells = <1>;
>  			#size-cells = <0>;
>  			reg = <4>;
> -			si5328: clock-generator@69 {/* SI5328 - u20 */
> -				reg = <0x69>;
> -				/*
> -				 * Chip has interrupt present connected to PL
> -				 * interrupt-parent = <&>;
> -				 * interrupts = <>;
> -				 */
> -				#address-cells = <1>;
> -				#size-cells = <0>;
> -				#clock-cells = <1>;
> -				clocks = <&refhdmi>;
> -				clock-names = "xtal";
> -				clock-output-names = "si5328";
> -
> -				si5328_clk: clk0@0 {
> -					reg = <0>;
> -					clock-frequency = <27000000>;
> -				};
> -			};
> +			/* SI5328 - u20 */
>  		};
>  		i2c@5 {
>  			#address-cells = <1>;
> 

Applied.
M