Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp1884937pxb; Mon, 8 Mar 2021 08:37:51 -0800 (PST) X-Google-Smtp-Source: ABdhPJw+1qvLB/SH1Dz3DSYL1AUWOiGHnWAf1PxbMYKFfz4437EMQIPPzHPQg31zmeGJ/JaXcgFE X-Received: by 2002:aa7:d656:: with SMTP id v22mr22608451edr.119.1615221471660; Mon, 08 Mar 2021 08:37:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615221471; cv=none; d=google.com; s=arc-20160816; b=LaMk1VdrfGD9PT2Ucf5VEoaJukkoSIkTZhNP6N4DdhmYGK4trAiDh40Cw7dbIqIfSd xMH/dCbnBW4mY8z3zCZMTdIQOmrh02QB0LLLGaSFEQS6RAevaDy4Yp3OQyV7JmLP5O9q uaaVnbbVHD5FIa75jCW66xNWTPiLXVbrUrjEG9+zjmYiDBXWUJm+fC3tbvY9p4X/vK9j WoQFmJSY8bLkq8SK4oS3xoJIBRqZwO9Fi1WQ9xLAZIZAvYxu8olom2kYDb6AySXxkdVK UrUjweb+fcBzW73dPrkM/fB7tO7fv+TgkEGNRT9JrtzVLZoN8FlHWZxSHK5rkFCNbVqO o+OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:date:cc:to:from:subject :message-id:ironport-sdr:ironport-sdr; bh=ixmkmXx/HMtSUI04sP3CeJPi198gOIL40lJo/AWOQIY=; b=GU/MEmVfXQO1y30v0PVW7ErnU2BKQ8ao3sYSwzCYPM+euxG4nR+Rvto1DZsaMsUjjV 8SIa5lpGerdET5yaEbFYf1bZdzQfP/cCekhLbBu/F1P7q8FKE9Xzs6oyGiP/mCijWjFm a/uG6uYC+iZPLkrGpC4N9sfZW9SA4E4icOm28UOsme5i9kZu0sw/tPNG6jkI744+dxNY 6LRdQYHXmpdp/ap6pTsOcZE7q/bHEeC2894fXtvZyFp1w0FMNZHsMgPbwglzls9KmlZT T9a4ARe2JDEZOmCAz5lgBibNIMCSBoeTx3NuEC9HDz0EMqHmU10t1dcF5cnf2USNEiEL as5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l33si8069125ede.161.2021.03.08.08.37.28; Mon, 08 Mar 2021 08:37:51 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230143AbhCHQgC (ORCPT + 99 others); Mon, 8 Mar 2021 11:36:02 -0500 Received: from mga17.intel.com ([192.55.52.151]:31798 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229459AbhCHQfp (ORCPT ); Mon, 8 Mar 2021 11:35:45 -0500 IronPort-SDR: MAFuZstgiFWPCSb+5dFfh1wTu5D3MfLjSXssUp8uqdrgzeQc05FNJosceiiZBCXywUir/6wW+Y bxv6QyF5vI1A== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="167974030" X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="167974030" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:35:45 -0800 IronPort-SDR: YiJNZGNGSZNsZsmLEzU/9Lnz/d1uyF5tA289sbh6idydDGnR7J6p+q8sDvRcA4hdR68XtPbFr4 yBQyHWUTt7fw== X-IronPort-AV: E=Sophos;i="5.81,232,1610438400"; d="scan'208";a="402882554" Received: from arohrbax-mobl.amr.corp.intel.com ([10.209.91.130]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Mar 2021 08:35:45 -0800 Message-ID: Subject: Re: [PATCH v1 1/3] HID: intel-ish-hid: Drop if block with an always false condition From: Srinivas Pandruvada To: Jiri Kosina Cc: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , Benjamin Tissoires , Enric Balletbo i Serra , Guenter Roeck , Greg Kroah-Hartman , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 08 Mar 2021 08:35:44 -0800 In-Reply-To: References: <20210206151348.14530-1-uwe@kleine-koenig.org> <31028f589e27e246bb3b4b693caeb0b8eae3a285.camel@linux.intel.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2021-03-08 at 17:16 +0100, Jiri Kosina wrote: > On Mon, 8 Mar 2021, Srinivas Pandruvada wrote: > > > > > A remove callback is only ever called for a bound device. So > > > > there > > > > is no > > > > need to check for device or driver being NULL. > > > > > > Srinivas, any objections to this patchset? The cleanups look good > > > to > > > me. > > Sorry, I missed this series. > > No objection for taking these patches. > > Thanks. Applied with your Acked-by: > If you disagree with that interpretation of your statement above, > please > holler :) I agree. For record: Acked-by: Srinivas Pandruvada Thanks, Srinivas > > Thanks, >