Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] Revert "pinctrl: intel: Split
 intel_pinctrl_add_padgroups() for better maintenance"
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Daniel Scally <djrscally@gmail.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <20210308152505.3762055-1-luzmaximilian@gmail.com>
 <YEZEX+BCw21O6rmT@smile.fi.intel.com>
 <c306b082-f97a-96d8-1291-78ff14c4ea88@gmail.com>
 <CAHp75Vd9N_U7NobAwpYkqGoOCVNYbBSTkZ1vpgziOfgAf=c0wQ@mail.gmail.com>
From:   Maximilian Luz <luzmaximilian@gmail.com>
Message-ID: <84a81a3f-cda4-6d0e-ee4d-700b4223b2ee@gmail.com>
Date:   Mon, 8 Mar 2021 17:44:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
MIME-Version: 1.0
In-Reply-To: <CAHp75Vd9N_U7NobAwpYkqGoOCVNYbBSTkZ1vpgziOfgAf=c0wQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 3/8/21 5:42 PM, Andy Shevchenko wrote:
> On Mon, Mar 8, 2021 at 6:34 PM Maximilian Luz <luzmaximilian@gmail.com> wrote:
>>
>> On 3/8/21 4:35 PM, Andy Shevchenko wrote:
>>> On Mon, Mar 08, 2021 at 04:25:05PM +0100, Maximilian Luz wrote:
>>>> Following commit 036e126c72eb ("pinctrl: intel: Split
>>>> intel_pinctrl_add_padgroups() for better maintenance"),
>>>> gpiochip_get_desc() is broken on some Kaby Lake R devices (specifically
>>>> a Microsoft Surface Book 2), returning -EINVAL for GPIOs that in reality
>>>> should be there (they are defined in ACPI and have been accessible
>>>> previously). Due to this, gpiod_get() fails with -ENOENT.
>>>>
>>>> Reverting this commit fixes that issue and the GPIOs in question are
>>>> accessible again.
>>>
>>> I would like to have more information.
>>> Can you enable PINCTRL and GPIO debug options in the kernel, and show dmesg
>>> output (when kernel command line has 'ignore_loglevel' option) for both working
>>> and non-working cases?
>>
>> Sure.
>>
>> Here are dmesg logs for:
>>
>>    - Kernel v5.12-rc2 (not working): https://paste.ubuntu.com/p/HVZybcvQDH/
> 
> Thanks!
> 
> Yeah, yeah... Please, test my patch, I am quite sure it will fix the issue.


It does indeed, thanks again!

Regards,
Max