Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: SjGcSfG9qxCxu4EpC8j/wQxl3hbIyCc40IRaisZt1pP444YpKjgI0KOld6gZkebrVHSbQziolF
 bN8uJddyjOdw==
IronPort-SDR: e6c1N2dqOoPH110DPXBYx5QfHr2DYwfK8jJfZBOnWJ31LPSNIcprKwpj+OAU3jcygEFrExL3Z6
 Km648+A4/yoQ==
Date:   Mon, 8 Mar 2021 18:51:37 +0200
From:   Mika Westerberg <mika.westerberg@linux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Maximilian Luz <luzmaximilian@gmail.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Show the GPIO base calculation
 explicitly
Message-ID: <20210308165137.GJ2542@lahna.fi.intel.com>
References: <20210308164910.87286-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210308164910.87286-1-andriy.shevchenko@linux.intel.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, Mar 08, 2021 at 06:49:10PM +0200, Andy Shevchenko wrote:
> During the split of intel_pinctrl_add_padgroups(), the _by_size() variant
> missed the GPIO base calculations and hence made unable to retrieve proper
> GPIO number.
> 
> Assign the gpio_base explicitly in _by_size() variant.
> 
> While at it, differentiate NOMAP case with the rest in _by_gpps() variant.
> 
> Fixes: 036e126c72eb ("pinctrl: intel: Split intel_pinctrl_add_padgroups() for better maintenance")
> Reported-and-tested-by: Maximilian Luz <luzmaximilian@gmail.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I think this needs stable tag too.

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>