Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 8 Mar 2021 23:07:30 +0100
From:   Jonathan =?utf-8?Q?Neusch=C3=A4fer?= <j.neuschaefer@gmx.net>
To:     Andreas Kemnade <andreas@kemnade.info>
Cc:     j.neuschaefer@gmx.net, lee.jones@linaro.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mfd: ntxec: Support for EC in Tolino Shine 2 HD
Message-ID: <YEagIqFSjGv3DDwq@latitude>
References: <20210308212952.20774-1-andreas@kemnade.info>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Qx9bk7+IN93x26sr"
Content-Disposition: inline
In-Reply-To: <20210308212952.20774-1-andreas@kemnade.info>
Precedence: bulk


--Qx9bk7+IN93x26sr
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Mar 08, 2021 at 10:29:52PM +0100, Andreas Kemnade wrote:
> Add the version of the EC in the Tolino Shine 2 HD
> to the supported versions. It seems not to have an RTC
> and does not ack data written to it.
> The vendor kernel happily ignores write errors, using
> I2C via userspace i2c-set also shows the error.
> So add a quirk to ignore that error.
>=20
> PWM can be successfully configured despite of that error.
>=20
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
[...]
>  	ec =3D devm_kmalloc(&client->dev, sizeof(*ec), GFP_KERNEL);
> @@ -137,6 +174,16 @@ static int ntxec_probe(struct i2c_client *client)
>  	/* Bail out if we encounter an unknown firmware version */
>  	switch (version) {
>  	case NTXEC_VERSION_KOBO_AURA:
> +		has_rtc =3D true;
> +		break;
> +	case NTXEC_VERSION_TOLINO_SHINE2:
> +		has_rtc =3D false;
> +		/* Another regmap stacked on top of the other */

"[...] on top of the first", perhaps

> +		ec->regmap =3D devm_regmap_init(ec->dev, NULL,
> +					      ec->regmap,
> +					      &regmap_config_noack);
> +		if (IS_ERR(ec->regmap))
> +			return PTR_ERR(ec->regmap);

In any case,

Reviewed-by: Jonathan Neusch=C3=A4fer <j.neuschaefer@gmx.net>

--Qx9bk7+IN93x26sr
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEvHAHGBBjQPVy+qvDCDBEmo7zX9sFAmBGoBoACgkQCDBEmo7z
X9vdnhAArtzeQk7O+n8dLYndtciZifv13aTgr4l7NWaKRltk4h+d0ul07hMmOAKg
R3LUE5yglRe8w55EAxEeDYCuCfL7oQDvO3A4+S9vQ8n379B/ugU9ff6GBlLA1DZU
RoRZxaUjHZA1WraPSW7/8+E5oZW5UqOT3e59vKhcmhBhqjlQC0XOf2d+v0WT1dpZ
Zuk/wEXorz/H88XstuQbhc8aSOQLSWGTRLApEb2KlSe9IEiSsctCq4Z9ak4sFldF
UdYuMravQtRfr0C4MnxnfYcdz/LJhSC9Z5Zm6L9Pi3fRntrLXsMW7jmk6qgkdTRh
s8Ju5/oPvEP1F3GO3vwGLGmILOyc4QwXNH1m2Wwtfsakr1gD1rPt/youG1X2lxmb
mu0ei9OxSVUtexyHzgrAHMGWbstyZfQCleI0etk2LnDyVDGnO+27yC+V/coW73cB
nb5tRnTIy/TYcwGaFJbbk84I2yN1MH9BGYuq011zzF12Jho04wD0NvRhbiSriMMV
O8fQPmqfTRjRpOOuZmAlDyG2iqvOJYK0IU0mtJH0EiLID4lF1980W2cKfBqPIx58
dXgVeMhd50XYvTSWBziA8rCut4R3IH4YiBMqKxj9LoXBlKXPOm4XHdbCxwXoNdSb
/2SJDNHVlnIhylgQC3t6eG5Bpc+RLasvS8zTW4PxxTQ8n9xpIFU=
=+i9v
-----END PGP SIGNATURE-----

--Qx9bk7+IN93x26sr--