Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2128642pxb; Mon, 8 Mar 2021 15:15:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnzY3T8trS8AcDFiWf56zUGUkpecLIkdsWbA3i6isw1fR9qUfQdarMmfWCJMWvm6yW2sJ0 X-Received: by 2002:a17:906:eda3:: with SMTP id sa3mr2946005ejb.147.1615245305375; Mon, 08 Mar 2021 15:15:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615245305; cv=none; d=google.com; s=arc-20160816; b=eVwUbN9q7g51vdO3grksDV/fclHzdNi5jvdS4B07QQpV+IH3RXL2bgdTr8hp5Ck3uO 6op4IE5fyNMCjL8Y8WGqFvqmRLj7zima7/8iKvrWW/JcBi78sqjxkU5Lnnj/x+m5IToS tbHBKgdww7MeYyh69uvKPPuAg9ZzKdNvzWOXNG9NR9ul+yTnk20HHbi3vpTfSpmxb87f wqlNO0t+gRx5TBeGJ22daA9g/2GLDgCygW4O+sFLzmb4Y8fv9chse6t0umF0l6reMbnd CYFiP1JrZiW0ZRDkddKGTB36WTrv75wZA5DPOr65WPsbk3nABtmuIRSgNZL6Hqq3V5pO IynQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=3sLOpMcNZFmK9gLPudJacF0X8QIMSGunlUsiZURia08=; b=aTeFdepIj18cz6fRWjnb+Kv/+8fJF/e9QQLslE4OY0GOoVArtkDAhysI5K0PESLVQ8 GJpVu4Xb3Gbmi/vfQXFBnHsIbeOU8PJUU+72qUIZ6nd2wrxXseWeXO+0da2oeaZIdGFk txY1GJ6KolErhmLU8gRw3acobG5vyGW1ilznbBfPGC6oKQoIVsmTf1qsTwyJy6q/9FAL LsIMQbCivCdyhOmEim0W92rKiRMjXF0G/FCpC3ekm63pJdBYh4rPTjVGw+yMbcSxfk+R ahsYNTXyGDvjutQexY5tcAW4wfa8nuUx1eQkX0MLITai/jqYGueqJptcpm0JntL+Me/A YLxA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g21si7385351ejf.645.2021.03.08.15.14.42; Mon, 08 Mar 2021 15:15:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230327AbhCHXLp (ORCPT + 99 others); Mon, 8 Mar 2021 18:11:45 -0500 Received: from mail-lj1-f181.google.com ([209.85.208.181]:38050 "EHLO mail-lj1-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229488AbhCHXLR (ORCPT ); Mon, 8 Mar 2021 18:11:17 -0500 Received: by mail-lj1-f181.google.com with SMTP id 2so18273835ljr.5; Mon, 08 Mar 2021 15:11:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=3sLOpMcNZFmK9gLPudJacF0X8QIMSGunlUsiZURia08=; b=U/M2o01m5ZkGabL/lrEBEoghe7baCK9o6LMw5rLZCXxvjaU+pF6bMZlvQ+MFbRbmUB S4IMyELVvobfvq+X3eIYo1PI+mOALvBtFFuqzGkTWSoSFxKM4XV1xaqbbTUer8PnrRc+ GWL5Pctataz4Lil6IIcJkp8R45G0NwtUHKUr56C5tzJBlgNFNV3QFFDTdR8aM/oppvIl vPj1K9X2NnBR9P16RrliXttN9FQaugncTjIN9uSzUVvM959OMTOdfpohpeJKbAHi8uHQ rgfu7WD5Q6OTcTiKH73jD5WW1E4jH4W52NhpSgVTmbAYBpk1/SYYyqg7F3e5AI/hNwXA 9r3g== X-Gm-Message-State: AOAM530ECDFXrjOBoOBDWZzmL2S8MxeiWXUNajogom1RQ8Tbpb6xJiZS G4xALIo+oKtyy+pcSzTO8wo= X-Received: by 2002:a2e:505d:: with SMTP id v29mr15153535ljd.131.1615245075594; Mon, 08 Mar 2021 15:11:15 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id v80sm1509340lfa.229.2021.03.08.15.11.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Mar 2021 15:11:15 -0800 (PST) Date: Tue, 9 Mar 2021 00:11:14 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Arnd Bergmann Cc: Lorenzo Pieralisi , Bjorn Helgaas , Arnd Bergmann , Rob Herring , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM Message-ID: References: <20210308152501.2135937-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210308152501.2135937-1-arnd@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > Compile-testing this driver without ECAM support results in a link > failure: > > ld.lld: error: undefined symbol: pci_ecam_map_bus > >>> referenced by pcie-al.c > >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a > > Select CONFIG_ECAM like the other drivers do. [...] Ouch. Thank you! Reviewed-by: Krzysztof WilczyƄski Krzysztof