Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2249187pxb; Mon, 8 Mar 2021 19:40:49 -0800 (PST) X-Google-Smtp-Source: ABdhPJw3Qay2MfT8IAts83ZkI7oJqBllEiGP+F733wgg2mmm+WebdC5B1CHNLxI922QomyOf02Kj X-Received: by 2002:a17:906:7c44:: with SMTP id g4mr17800950ejp.269.1615261249038; Mon, 08 Mar 2021 19:40:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615261249; cv=none; d=google.com; s=arc-20160816; b=WOQtAnDOL7NKWt1yfLs8H2YeCRj1+mVJ9TKIcHv1b6LbdTK8qLplez+fnYczA7zv+o Tt3hPzqTJosSz0dKIAT41ZlcZ9Q2O6J4vBl5vJzV1QM/N2tb+O7haa0MYZ4dGU7nccSE 17OspojOgU2aXQxppMeuSWANQcIyvM5QyhWhP77xSBrQ2puQBToTMwcJmY57wVapI3ID 6hUFH74r9M3egvE8MXCp05albO9ILmAQZ6aa2BfiXrUXhAR6jxDHKA61Ap/fc+3E7+7L 2PaBCF1uKRr3gdmEoeJ3MUvFtcEIxcZr2oStPzYjbziZOUiUwQ8chvdzq7hOodJMpcai 0O1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=4D3iz4wbWdEXorWEhbjBIx8Gd9Gz8Vo3tv1xTTC5jj4=; b=gW8/6baC6EP0xossLh30dAjJK1sB8SRLIDcMvxO5fQu37EWcr0c8DnT6PiMFNdIPu4 47cf9E560GANpaS4frxSXcU/ybO4s21GE7QH/ToxkW706/OPCdHf/0r6kKWI/cO/BapH YAvTHRMAT2IojqMTHupnoWAiz3C1EqC5fMke7cZwv+ZZcNz1f9jnA5LCcm9SUhrtqJbx 7b+N6h/3bJfGCkSmobVqdoNuj+bnOjEEKeEBfm+odwg8BJ8Bv/tGt9VTUx77cw29TiHe 43bB/zNnFdLzc2UT/Dd3ym9REOooa/9Lf0kmlePtMzbOCPyQgGJp5CpiFCfRWalWJi81 gi1g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si888262edj.210.2021.03.08.19.40.23; Mon, 08 Mar 2021 19:40:49 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229951AbhCIDjY (ORCPT + 99 others); Mon, 8 Mar 2021 22:39:24 -0500 Received: from out30-130.freemail.mail.aliyun.com ([115.124.30.130]:59714 "EHLO out30-130.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbhCIDjX (ORCPT ); Mon, 8 Mar 2021 22:39:23 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UR.n5AG_1615261154; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UR.n5AG_1615261154) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Mar 2021 11:39:21 +0800 From: Jiapeng Chong To: oliver@neukum.org Cc: aliakc@web.de, lenehan@twibble.org, jejb@linux.ibm.com, martin.petersen@oracle.com, dc395x@twibble.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] scsi: dc395x: Use bitwise instead of arithmetic operator for flags Date: Tue, 9 Mar 2021 11:39:13 +0800 Message-Id: <1615261153-32647-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warnings: ./drivers/scsi/dc395x.c:2921:28-29: WARNING: sum of probable bitmasks, consider |. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/scsi/dc395x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c index 3ea345c1..91362e6 100644 --- a/drivers/scsi/dc395x.c +++ b/drivers/scsi/dc395x.c @@ -2918,7 +2918,7 @@ static void disconnect(struct AdapterCtlBlk *acb) } else { if ((srb->state & (SRB_START_ + SRB_MSGOUT)) || !(srb-> - state & (SRB_DISCONNECT + SRB_COMPLETED))) { + state & (SRB_DISCONNECT | SRB_COMPLETED))) { /* * Selection time out * SRB_START_ || SRB_MSGOUT || (!SRB_DISCONNECT && !SRB_COMPLETED) -- 1.8.3.1