Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: WPAgq3cVmbs9CC5IfdUpTZgwg5W9i+rSOtuQhPj+7bMLMOfihRVTls3hCm4ZM00ZlucDj1u97P
 cTYhLUj8RYnA==
IronPort-SDR: xAF1BZV6aIdcX20k5nC8IpvHiYys6X3Et9tEMjHpto2M/YBoqJSX2oqhqtzsJQOZ5ZTeo9T2mL
 SBhf6BtnJMXA==
Date:   Tue, 9 Mar 2021 11:47:42 +0800
From:   "Ye, Xiang" <xiang.ye@intel.com>
To:     Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
        Jiri Kosina <jikos@kernel.org>
Cc:     jic23@kernel.org, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit
 during suspend/resume
Message-ID: <20210309034742.GA18299@host>
References: <20210303062825.7724-1-xiang.ye@intel.com>
 <nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm>
 <00ad0906b90a290e9737b7bf7d8c5ab9c6ed61e6.camel@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <00ad0906b90a290e9737b7bf7d8c5ab9c6ed61e6.camel@linux.intel.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

Hi Srinivas, Jiri

On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote:
> On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote:
> > On Wed, 3 Mar 2021, Ye Xiang wrote:
> > 
> > > ISH firmware uses connected standby state bit
> > > (CONNECTED_STANDBY_STATE_BIT bit 1)
> > > to notify current power state to sensors instead of suspend state
> > > bit (bit 0).
> > > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to
> > > firmware
> > > to be compatible with the previous version.
> > 
> > Could you please make the changelog more verbose -- namely what 
> > user-visible issue this is fixing?
> Xiang,
> 
> I think this change is for related to Elkhart Lake for support of
> connected standby (keep listening for sensor events during Linux
> suspend for some sensors). In this way some sensor can wake up the
> system.
This change is for all ISH platform. Currently, ISH firmware use
both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to identify
system state. It is related to system wake up by ISH and it enable each
sensor in ISH to be notified the current system state, when system state
change.

Thanks
Ye Xiang
> 
> 
> 
> 
> 
> 
>