Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2298901pxb; Mon, 8 Mar 2021 21:39:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJx5drBL08XFWB8kDDa7PSRd+pfj93+je9HXER4GnC/g77PzG0NfSWEEJFX1awI+2V7lSjIw X-Received: by 2002:a05:6402:142:: with SMTP id s2mr2154682edu.2.1615268342716; Mon, 08 Mar 2021 21:39:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615268342; cv=none; d=google.com; s=arc-20160816; b=qfGjVkvzLg9BRcn/jL64WbWmWZaSbFPz8m3BUnQ62DNvVvv1m+FYPsktqKA46uzRrJ J9/28WRo2+6PIorSKhjcNT3sijo7glF7dX1M7UKAxlwNQLhEVffqEcwT0EHDpV5karYY rgDkNTTnoBngXjf/W17Fb2tFhF45EWrLx25aub4OFg9M60eHmlRdsPhY7JGpPNNLu9At N36I7cmynybNR5CcfydR6pyObuWbZcitC2EvuGtd7rW3/P6faCmtYJUjFtWDshHbUF3u pPxUBiGr/QF5Y/bJXW2wQpcDMFItxNvQm+N+et/kybp+OBhAHVgEtza2zAFJnCJCujqk TIHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=QlNk/H6vB3rQVOKoCjE25n2ugJ3x/YFGbjBeIgssnms=; b=I93VGpf4Pai8yTsXtUgyPjSPD/ssKKIYf3DhrV0JHlT/VBdeFE6kAOY7HhIzTmIDuB /frifTTd48/g0lEQcGKOQDYshmCXZeqwuS+AfxSieKxKZub22H0uoA/ondjVIgXK777e oj8ER3oZm9D4LcovlLE8gU8vSZYw4xXzAOJXJXs8ZQDlHvR59UCH7xfG5b8bkUBz/QNi nwrmvIEoGV5yu/4uEdgJ0cBpfMgok2tDi4AfxugCML1KhMThBgG79vhiGH6xHYa4QRLe 6lYB15iuvEb8Fcu7+fVR7muoHLc66WUrXBsIiM3d90CgfHcvLUtat5gHBBos2TNp6zcj bgQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=XZkoUB40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hp6si810768ejc.115.2021.03.08.21.38.39; Mon, 08 Mar 2021 21:39:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=XZkoUB40; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229495AbhCIFho (ORCPT + 99 others); Tue, 9 Mar 2021 00:37:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:41020 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhCIFhS (ORCPT ); Tue, 9 Mar 2021 00:37:18 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7D6716518A; Tue, 9 Mar 2021 05:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1615268238; bh=hmD3UkvOhmgPEIlYWZbQKRstKfX1ya1CgO7lMiascIs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XZkoUB40gNnfL6kAGhMzXQRkkzQB6m3VlAdwXsRpOoHrHV0Wv3Ik0RyUJn3ka1uO6 hguzcqaFTNFg3yOFcd8ZTLc9hUBsULQgA+Ok6f5lyQsy2yzEh75nmDaFnXN74Sp05v 6hgporgleSYRcjT1wHzpIndsktCaAgq9LDQvmlWY= Date: Mon, 8 Mar 2021 21:37:17 -0800 From: Andrew Morton To: Phillip Lougher Cc: "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] Squashfs: fix xattr id and id lookup sanity checks Message-Id: <20210308213717.e319cbf5675a5e427efbdded@linux-foundation.org> In-Reply-To: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk> References: <2069685113.2081245.1614583677427@webmail.123-reg.co.uk> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Mar 2021 07:27:57 +0000 (GMT) Phillip Lougher wrote: > The checks for maximum metadata block size is > missing SQUASHFS_BLOCK_OFFSET (the two byte length > count). There is no definition of SQUASHFS_BLOCK_OFFSET. Makes compiler unhappy.