Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2328447pxb; Mon, 8 Mar 2021 22:44:45 -0800 (PST) X-Google-Smtp-Source: ABdhPJyURs+OVFLgS9mpwaPIx7TtFeahZOHXW6kkp99PAJCyJCL+ljWXwvL1Z1WK/MoEYuk87t/s X-Received: by 2002:a17:906:8147:: with SMTP id z7mr17846286ejw.436.1615272285372; Mon, 08 Mar 2021 22:44:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615272285; cv=none; d=google.com; s=arc-20160816; b=0yDdKmRYS63tvDODiZCI8gu45WNkdNHXvKPbscoAW2aAejiPBkhMH1Y/OYGmsn3A9a 3cQmJHa20MdnBE6JUblvEPKgiC4EzPqiaDR/yRb+smtzxOyG1/uJeJwW2WjYElr3UDGS E6dt4NMYzAZFiyZ/IWQ2X9TiVTTOtGhHIxZZWpNM0XJMPjPsK4TTrRqn2lCP98mmCK40 g7HsmMwN19RhE9HZhVyHDR7SXOkTD4DMK2cj+XBWHZ0yG1q+w8fZoTiVpDaT6u5sPdC5 FdLnHFsueOcifnqG13eZXS42kHBkNhkYsECYzHZHZ453wYkGI4NFF0bqgfSvJlmVyskv hXhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=FrJCvPRni1+bFSNGTt89W+jHxwntb6p4wdMpVkjvDFA=; b=m+yHhU6vM2Je0wkPO3P9dANsUts9dlFUcVGBxcW/bz5zjbTOqqYnUrE0RRJ1lb4KtH j0OoCNjG9lSbRMe0YmNrL5xyqX1jKtn+pT/RIyfWYW36cep1Ql89niIKOkD1GiXJ4Na5 vMP9WXNQyyG/GzMfh+7o0cvh3qMCZ5hI60Y9KXYNOOANYAbHbnT+StkT/LF+LSraa6lv U7o17AA3JKyG1dkICdsTf0mT7b1MjQzuTLjORQg0uY9bh+9HVafLGjvFJRAP6HH5KqzL 3Wb4JsG+ksOC4/drkFX5sxlAEGJDLfbbUKiqnZta6HwBwlHbCoGwemMe0gEzSplSZqPX Iq9w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id yr5si8202314ejb.728.2021.03.08.22.44.21; Mon, 08 Mar 2021 22:44:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhCIGlP (ORCPT + 99 others); Tue, 9 Mar 2021 01:41:15 -0500 Received: from out30-131.freemail.mail.aliyun.com ([115.124.30.131]:57091 "EHLO out30-131.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229689AbhCIGlL (ORCPT ); Tue, 9 Mar 2021 01:41:11 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UR1u9NJ_1615272065; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UR1u9NJ_1615272065) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Mar 2021 14:41:06 +0800 From: Yang Li To: aradford@gmail.com Cc: jejb@linux.ibm.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] scsi: 3w-sas: remove unneeded variable 'retval' Date: Tue, 9 Mar 2021 14:41:04 +0800 Message-Id: <1615272064-42109-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/scsi/3w-sas.c:866:5-11: Unneeded variable: "retval". Return "1" on line 898 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/scsi/3w-sas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/3w-sas.c b/drivers/scsi/3w-sas.c index 3db0e42..eae706e 100644 --- a/drivers/scsi/3w-sas.c +++ b/drivers/scsi/3w-sas.c @@ -863,7 +863,6 @@ static int twl_fill_sense(TW_Device_Extension *tw_dev, int i, int request_id, in TW_Command_Full *full_command_packet; unsigned short error; char *error_str; - int retval = 1; header = tw_dev->sense_buffer_virt[i]; full_command_packet = tw_dev->command_packet_virt[request_id]; @@ -895,7 +894,7 @@ static int twl_fill_sense(TW_Device_Extension *tw_dev, int i, int request_id, in goto out; } out: - return retval; + return 1; } /* End twl_fill_sense() */ /* This function will free up device extension resources */ -- 1.8.3.1