Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2328669pxb;
        Mon, 8 Mar 2021 22:45:12 -0800 (PST)
X-Google-Smtp-Source: ABdhPJwe+lJtMNc7vm4CCNu9v55i4TY4GhNp6ZbnhZXqPgQtiJ6Du0y5+s4iSTgpf6zLR3HbMBPS
X-Received: by 2002:a50:f9c8:: with SMTP id a8mr2394038edq.270.1615272312761;
        Mon, 08 Mar 2021 22:45:12 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1615272312; cv=none;
        d=google.com; s=arc-20160816;
        b=ZPbAVhRwyvxmD9HiBs9YT+fU8Iz8TmTnW4FE/ga5UDgwxaxAjEvZjwRYNk/EmzdKH9
         A/z81SJzo1XN0c/vbhKAH+UtjnFNi1WlnZnEUE71/uAsd4lzvQoE0YuKF5GyggQNx9Qx
         PlHWbEx3lmfRSo+izRR7ZG0M+zHh5ePUjQWKPWTmq/hhymFJNSMFtZLUZfX1CPcrKJkH
         mOtK1SXhsz0dtQU/JpP97oMmpH9NObGqR6jl/7Eqa5NI63dnoI6OJIvVgtz4XV8UcSPU
         CT0bmu+Wu9IUqcjfaJKWW/6+avdtOKBjm7+BrayhTOfw168KhXWD+0Rqt39924zQ3UZr
         2Kwg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:mime-version:user-agent:references:in-reply-to
         :subject:cc:to:from:message-id:date;
        bh=3FTUek3ibRyUcADmF1MlSVnwZgGONPdbbK5NtYw9GmQ=;
        b=T9hFWEZrbYSWS/lFFr3dSaIB5P3BrFH2zPtKzCbUBPfzrzqURGxfaPHzku+r0y9K7O
         7FvjzAj1hhPiaYpGOgbPvKAWsxqsgAryeEETQFPxH0Z2t5v6bOwtFQEg/TmJI6c2JD4U
         f/epcKyfOrxGtX5+leNmmJZ1JbCUxvGwcBTD5OHVBVhVl+3Q+XtqJl6mUpLi9/lsqMf+
         rp5DK0TAtGvli7A3on0N1jHLkFdL3YDupjgXnxLwUPdToYenb1BGH6HZoJIsfTmqL0QJ
         dpOBSbzCLM4ZsuV80THAtD3hP4Ykmr5iwLLNyqSjclmrkTdyLeBiRqIY2ls5TOFvOZkk
         eVvA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id b7si8878417ejv.268.2021.03.08.22.44.50;
        Mon, 08 Mar 2021 22:45:12 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S229805AbhCIGny (ORCPT <rfc822;ly15351151@gmail.com> + 99 others);
        Tue, 9 Mar 2021 01:43:54 -0500
Received: from mx2.suse.de ([195.135.220.15]:58474 "EHLO mx2.suse.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229649AbhCIGnf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 9 Mar 2021 01:43:35 -0500
X-Virus-Scanned: by amavisd-new at test-mx.suse.de
Received: from relay2.suse.de (unknown [195.135.221.27])
        by mx2.suse.de (Postfix) with ESMTP id 3438AAB8C;
        Tue,  9 Mar 2021 06:43:34 +0000 (UTC)
Date:   Tue, 09 Mar 2021 07:43:34 +0100
Message-ID: <s5hh7lk3jzd.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Pavel Skripkin <paskripkin@gmail.com>
Cc:     perex@perex.cz, tiwai@suse.com, kai.heng.feng@canonical.com,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH next 2/2] sound: usb: fix use after free in usb_audio_disconnect
In-Reply-To: <16da19126ff461e5e64a9aec648cce28fb8ed73e.1615242183.git.paskripkin@gmail.com>
References: <cover.1615242183.git.paskripkin@gmail.com>
        <16da19126ff461e5e64a9aec648cce28fb8ed73e.1615242183.git.paskripkin@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 08 Mar 2021 23:30:57 +0100,
Pavel Skripkin wrote:
> 
> The problem was in wrong "if" placement. chip->quirk_type is freed
> in snd_card_free_when_closed(), but inside if statement it's accesed.
> 
> Fixes: 9799110825db ("ALSA: usb-audio: Disable USB autosuspend properly in setup_disable_autosuspend()"
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>

Thanks, applied now.


Takashi