Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] net: netlink: fix error return code of
 netlink_proto_init()
To:     Heiner Kallweit <hkallweit1@gmail.com>, davem@davemloft.net,
        kuba@kernel.org, ast@kernel.org, daniel@iogearbox.net,
        andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com,
        john.fastabend@gmail.com, kpsingh@kernel.org,
        marcelo.leitner@gmail.com, mkubecek@suse.cz, jbi.octave@gmail.com,
        yangyingliang@huawei.com, 0x7f454c46@gmail.com,
        rdunlap@infradead.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        bpf@vger.kernel.org
References: <20210309083356.24083-1-baijiaju1990@gmail.com>
 <1ca491b5-1c65-6dee-1f8c-d86006714b51@gmail.com>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <fb1e13d8-6b7e-ca47-2f65-930dfdb651dc@gmail.com>
Date:   Tue, 9 Mar 2021 16:55:34 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <1ca491b5-1c65-6dee-1f8c-d86006714b51@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2021/3/9 16:47, Heiner Kallweit wrote:
> On 09.03.2021 09:33, Jia-Ju Bai wrote:
>> When kcalloc() returns NULL to nl_table, no error return code of
>> netlink_proto_init() is assigned.
>> To fix this bug, err is assigned with -ENOMEM in this case.
>>
> Didn't we talk enough about your incorrect patches yesterday?
> This one is incorrect again. panic() never returns.
> Stop sending patches until you understand the code you're changing!

Ah, sorry, I was too confident about this bug report...
Thanks for your reply.
Following your advice, now I am sending the patches only for the bug 
reports that I am confident about after careful code review.
Some of the patches have been applied, but some of them are still wrong, 
like this patch...
I am sorry for the false positives...


Best wishes,
Jia-Ju Bai