Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Andy Shevchenko' <andriy.shevchenko@linux.intel.com>,
        Marco Elver <elver@google.com>
CC:     Petr Mladek <pmladek@suse.com>,
        Geert Uytterhoeven <geert@linux-m68k.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Vlastimil Babka <vbabka@suse.cz>,
        Timur Tabi <timur@kernel.org>,
        Steven Rostedt <rostedt@goodmis.org>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Rasmus Villemoes <linux@rasmusvillemoes.dk>
Subject: RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers
 warning
Thread-Topic: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers
 warning
Thread-Index: AQHXFEobJ7Swwp6RcU2yBDODqe2J7ap7X8pg
Date:   Tue, 9 Mar 2021 09:12:40 +0000
Message-ID: <d8113f0273494e76b7b10c9d81d7997e@AcuMS.aculab.com>
References: <20210305194206.3165917-1-elver@google.com>
 <20210305194206.3165917-2-elver@google.com> <YEX5fyB16dF6N4Iu@alley>
 <CAMuHMdUDqcWfE67g2ah-JyL3H9-G_5nrtQLyq0A3OXTKPFXv6w@mail.gmail.com>
 <YEZdo0L8otuEJZNW@alley>
 <CANpmjNOS86kLPexXBZPwRB9=Ej6RHycJXCw_Z7cskMC+Jwb1Ag@mail.gmail.com>
 <YEZupyBiJD1zoLTi@smile.fi.intel.com>
In-Reply-To: <YEZupyBiJD1zoLTi@smile.fi.intel.com>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

...
> On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote:
> > On Mon, 8 Mar 2021 at 18:23, Petr Mladek <pmladek@suse.com> wrote:
> 
> > > -       pr_warn("**********************************************************\n");
> > > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("** This system shows unhashed kernel memory addresses   **\n");
> > > -       pr_warn("** via the console, logs, and other interfaces. This    **\n");
> > > -       pr_warn("** might reduce the security of your system.            **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("** If you see this message and you are not debugging    **\n");
> > > -       pr_warn("** the kernel, report this immediately to your system   **\n");
> >
> > While we're here: This paragraph can be shortened by saying what
> > kernel/trace/trace.c says ("..., report this immediately to your
> > vendor!") which avoids the "administrator! <lots of wasted spaces>".
> 
> Aren't we discussed that and the point was that kernel configuration option is
> in administrator's realm?
> 
> > > -       pr_warn("** administrator!                                       **\n");
> > > -       pr_warn("**                                                      **\n");
> > > -       pr_warn("**   NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE   **\n");
> > > -       pr_warn("**********************************************************\n");

If you actually want anyone to notice it you need to splat it out
when root logs in - not just hidden in the middle of the boot messages.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)