Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2409967pxb; Tue, 9 Mar 2021 01:37:03 -0800 (PST) X-Google-Smtp-Source: ABdhPJzlLRziwfbi/e4mt8vXHGbp+x3Cp1a5S8XV8HIJxTjXZUDDGL3IwjaUsJwzresDiQC6x5oY X-Received: by 2002:a05:6402:100c:: with SMTP id c12mr3056894edu.200.1615282623359; Tue, 09 Mar 2021 01:37:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615282623; cv=none; d=google.com; s=arc-20160816; b=Y7XwZF/edf02TehozUXMttbE8mWsvsKidjI3pbbGC5GsgF6G5n8PRI2ai9yT34294U tzh7O49BV2Hav5ZV+YmRn197ByvvIvhhgivzauJ3Q0GtVQBX/69+Ga068bJwG8c5S57w sPk28jLSqaPw2tb+j/+qxXb8tXmPjeCd0fapzFlDCUyt2zB3XIP40FxqfBXiCU8vC3ni 79RudCy38o75+p+44V+o5Wy651N7IuOnrsezzE3URoctrn2oJiXYWSR/jP7LmAfvU8T+ XbT7EaZbKiP8Nzq4zli8qqE+KpxRcs43qVxlxWNKXla988ocw56/MUdrTfSkzaDRk/Oh U2ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=Pl4ODJ0EjH+MHLiyKX3FMxMB/kAwzHg4ARHdqebGlu0=; b=KCoF1cUQrCtGfQOiNYaTFe4b0yyPS2ERyMmar9q/2IutRnCzu2FZLXvlGmWwykXfyl pDW4faW1ITxbRNZZkSJwPHVBbrmKD5T3UmZMOq0tlOc2braM3aOsNK36pBemUJiCg/xo RRa+zKp4MKPsC/EORzZy7WDd4L58FFHYV0l0oKJGwgFI5dERxtznziYCcFEW9anR6XsF SPe4YbkbEyo/48G+XEMG4JvvVuf++fK0IZR1tDzWW0Sbtu6tu5eOMFpkfbVcSq3cdBu2 zjvV3HSEVPXX7bkTFMy+6h2+hH/YBOblqejDpMYUKg7WqiKV3+zHPiuOitvscMUqeElD 34Bg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id lx16si6219357ejb.344.2021.03.09.01.36.40; Tue, 09 Mar 2021 01:37:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229948AbhCIJdH (ORCPT + 99 others); Tue, 9 Mar 2021 04:33:07 -0500 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:50107 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230122AbhCIJc7 (ORCPT ); Tue, 9 Mar 2021 04:32:59 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UR4gjPW_1615282375; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0UR4gjPW_1615282375) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Mar 2021 17:32:56 +0800 From: Yang Li To: clm@fb.com Cc: josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] btrfs: turn btrfs_destroy_delayed_refs() into void function Date: Tue, 9 Mar 2021 17:32:54 +0800 Message-Id: <1615282374-29598-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./fs/btrfs/disk-io.c:4522:5-8: Unneeded variable: "ret". Return "0" on line 4530 Reported-by: Abaci Robot Signed-off-by: Yang Li --- fs/btrfs/disk-io.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 41b718c..b75d2d9 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -52,7 +52,7 @@ static void end_workqueue_fn(struct btrfs_work *work); static void btrfs_destroy_ordered_extents(struct btrfs_root *root); -static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, +static void btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, struct btrfs_fs_info *fs_info); static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root); static int btrfs_destroy_marked_extents(struct btrfs_fs_info *fs_info, @@ -4513,13 +4513,12 @@ static void btrfs_destroy_all_ordered_extents(struct btrfs_fs_info *fs_info) btrfs_wait_ordered_roots(fs_info, U64_MAX, 0, (u64)-1); } -static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, +static void btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, struct btrfs_fs_info *fs_info) { struct rb_node *node; struct btrfs_delayed_ref_root *delayed_refs; struct btrfs_delayed_ref_node *ref; - int ret = 0; delayed_refs = &trans->delayed_refs; @@ -4592,8 +4591,6 @@ static int btrfs_destroy_delayed_refs(struct btrfs_transaction *trans, btrfs_qgroup_destroy_extent_records(trans); spin_unlock(&delayed_refs->lock); - - return ret; } static void btrfs_destroy_delalloc_inodes(struct btrfs_root *root) -- 1.8.3.1