Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [RESEND PATCH v5 4/4] dt-bindings: devfreq: rk3399_dmc: Remove
 references of unexistant defines
To:     Daniel Lezcano <daniel.lezcano@linaro.org>, heiko@sntech.de
Cc:     linux-arm-kernel@lists.infradead.org,
        linux-rockchip@lists.infradead.org,
        =?UTF-8?Q?Ga=c3=abl_PORTAY?= <gael.portay@collabora.com>,
        MyungJoo Ham <myungjoo.ham@samsung.com>,
        Kyungmin Park <kyungmin.park@samsung.com>,
        Rob Herring <robh+dt@kernel.org>,
        "open list:DEVICE FREQUENCY (DEVFREQ)" <linux-pm@vger.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
From:   Chanwoo Choi <cw00.choi@samsung.com>
Organization: Samsung Electronics
Message-ID: <4c2c9145-d404-0c3b-e0c8-b4404dc1ea20@samsung.com>
Date:   Tue, 9 Mar 2021 19:16:34 +0900
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:59.0) Gecko/20100101
        Thunderbird/59.0
MIME-Version: 1.0
In-Reply-To: <20210308233858.24741-4-daniel.lezcano@linaro.org>
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 101P
DLP-Filter: Pass
References: <20210308233858.24741-1-daniel.lezcano@linaro.org>
        <CGME20210308234059epcas1p1f68056155634a407d62d2ed52e2729da@epcas1p1.samsung.com>
        <20210308233858.24741-4-daniel.lezcano@linaro.org>
Precedence: bulk

On 3/9/21 8:38 AM, Daniel Lezcano wrote:
> From: Gaël PORTAY <gael.portay@collabora.com>
> 
> Those DDR related defines do not exist. Replace their references with
> their numerical constant.
> 
> Signed-off-by: Gaël PORTAY <gael.portay@collabora.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
>  .../bindings/devfreq/rk3399_dmc.txt           | 73 +++++++++----------
>  1 file changed, 34 insertions(+), 39 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
> index a41bcfef95c8..ddde2c4f97df 100644
> --- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
> +++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
> @@ -79,24 +79,23 @@ Following properties relate to DDR timing:
>  
>  - rockchip,ddr3_drv :		  When the DRAM type is DDR3, this parameter defines
>  				  the DRAM side driver strength in ohms. Default
> -				  value is DDR3_DS_40ohm.
> +				  value is 40.
>  
>  - rockchip,ddr3_odt :		  When the DRAM type is DDR3, this parameter defines
>  				  the DRAM side ODT strength in ohms. Default value
> -				  is DDR3_ODT_120ohm.
> +				  is 120.
>  
>  - rockchip,phy_ddr3_ca_drv :	  When the DRAM type is DDR3, this parameter defines
>  				  the phy side CA line (incluing command line,
>  				  address line and clock line) driver strength.
> -				  Default value is PHY_DRV_ODT_40.
> +				  Default value is 40.
>  
>  - rockchip,phy_ddr3_dq_drv :	  When the DRAM type is DDR3, this parameter defines
>  				  the PHY side DQ line (including DQS/DQ/DM line)
> -				  driver strength. Default value is PHY_DRV_ODT_40.
> +				  driver strength. Default value is 40.
>  
>  - rockchip,phy_ddr3_odt : 	  When the DRAM type is DDR3, this parameter defines
> -				  the PHY side ODT strength. Default value is
> -				  PHY_DRV_ODT_240.
> +				  the PHY side ODT strength. Default value is 240.
>  
>  - rockchip,lpddr3_odt_dis_freq : When the DRAM type is LPDDR3, this parameter defines
>  				  then ODT disable frequency in MHz (Mega Hz).
> @@ -106,25 +105,23 @@ Following properties relate to DDR timing:
>  
>  - rockchip,lpddr3_drv :		  When the DRAM type is LPDDR3, this parameter defines
>  				  the DRAM side driver strength in ohms. Default
> -				  value is LP3_DS_34ohm.
> +				  value is 34.
>  
>  - rockchip,lpddr3_odt :		  When the DRAM type is LPDDR3, this parameter defines
>  				  the DRAM side ODT strength in ohms. Default value
> -				  is LP3_ODT_240ohm.
> +				  is 240.
>  
>  - rockchip,phy_lpddr3_ca_drv :	  When the DRAM type is LPDDR3, this parameter defines
>  				  the PHY side CA line (including command line,
>  				  address line and clock line) driver strength.
> -				  Default value is PHY_DRV_ODT_40.
> +				  Default value is 40.
>  
>  - rockchip,phy_lpddr3_dq_drv :	  When the DRAM type is LPDDR3, this parameter defines
>  				  the PHY side DQ line (including DQS/DQ/DM line)
> -				  driver strength. Default value is
> -				  PHY_DRV_ODT_40.
> +				  driver strength. Default value is 40.
>  
>  - rockchip,phy_lpddr3_odt : 	  When dram type is LPDDR3, this parameter define
> -				  the phy side odt strength, default value is
> -				  PHY_DRV_ODT_240.
> +				  the phy side odt strength, default value is 240.
>  
>  - rockchip,lpddr4_odt_dis_freq : When the DRAM type is LPDDR4, this parameter
>  				  defines the ODT disable frequency in
> @@ -134,32 +131,30 @@ Following properties relate to DDR timing:
>  
>  - rockchip,lpddr4_drv :		  When the DRAM type is LPDDR4, this parameter defines
>  				  the DRAM side driver strength in ohms. Default
> -				  value is LP4_PDDS_60ohm.
> +				  value is 60.
>  
>  - rockchip,lpddr4_dq_odt : 	  When the DRAM type is LPDDR4, this parameter defines
>  				  the DRAM side ODT on DQS/DQ line strength in ohms.
> -				  Default value is LP4_DQ_ODT_40ohm.
> +				  Default value is 40.
>  
>  - rockchip,lpddr4_ca_odt :	  When the DRAM type is LPDDR4, this parameter defines
>  				  the DRAM side ODT on CA line strength in ohms.
> -				  Default value is LP4_CA_ODT_40ohm.
> +				  Default value is 40.
>  
>  - rockchip,phy_lpddr4_ca_drv :	  When the DRAM type is LPDDR4, this parameter defines
>  				  the PHY side CA line (including command address
> -				  line) driver strength. Default value is
> -				  PHY_DRV_ODT_40.
> +				  line) driver strength. Default value is 40.
>  
>  - rockchip,phy_lpddr4_ck_cs_drv : When the DRAM type is LPDDR4, this parameter defines
>  				  the PHY side clock line and CS line driver
> -				  strength. Default value is PHY_DRV_ODT_80.
> +				  strength. Default value is 80.
>  
>  - rockchip,phy_lpddr4_dq_drv :	  When the DRAM type is LPDDR4, this parameter defines
>  				  the PHY side DQ line (including DQS/DQ/DM line)
> -				  driver strength. Default value is PHY_DRV_ODT_80.
> +				  driver strength. Default value is 80.
>  
>  - rockchip,phy_lpddr4_odt :	  When the DRAM type is LPDDR4, this parameter defines
> -				  the PHY side ODT strength. Default value is
> -				  PHY_DRV_ODT_60.
> +				  the PHY side ODT strength. Default value is 60.  
>  
>  Example:
>  	dmc_opp_table: dmc_opp_table {
> @@ -195,23 +190,23 @@ Example:
>  		rockchip,phy_dll_dis_freq = <125>;
>  		rockchip,auto_pd_dis_freq = <666>;
>  		rockchip,ddr3_odt_dis_freq = <333>;
> -		rockchip,ddr3_drv = <DDR3_DS_40ohm>;
> -		rockchip,ddr3_odt = <DDR3_ODT_120ohm>;
> -		rockchip,phy_ddr3_ca_drv = <PHY_DRV_ODT_40>;
> -		rockchip,phy_ddr3_dq_drv = <PHY_DRV_ODT_40>;
> -		rockchip,phy_ddr3_odt = <PHY_DRV_ODT_240>;
> +		rockchip,ddr3_drv = <40>;
> +		rockchip,ddr3_odt = <120>;
> +		rockchip,phy_ddr3_ca_drv = <40>;
> +		rockchip,phy_ddr3_dq_drv = <40>;
> +		rockchip,phy_ddr3_odt = <240>;
>  		rockchip,lpddr3_odt_dis_freq = <333>;
> -		rockchip,lpddr3_drv = <LP3_DS_34ohm>;
> -		rockchip,lpddr3_odt = <LP3_ODT_240ohm>;
> -		rockchip,phy_lpddr3_ca_drv = <PHY_DRV_ODT_40>;
> -		rockchip,phy_lpddr3_dq_drv = <PHY_DRV_ODT_40>;
> -		rockchip,phy_lpddr3_odt = <PHY_DRV_ODT_240>;
> +		rockchip,lpddr3_drv = <34>;
> +		rockchip,lpddr3_odt = <240>;
> +		rockchip,phy_lpddr3_ca_drv = <40>;
> +		rockchip,phy_lpddr3_dq_drv = <40>;
> +		rockchip,phy_lpddr3_odt = <240>;
>  		rockchip,lpddr4_odt_dis_freq = <333>;
> -		rockchip,lpddr4_drv = <LP4_PDDS_60ohm>;
> -		rockchip,lpddr4_dq_odt = <LP4_DQ_ODT_40ohm>;
> -		rockchip,lpddr4_ca_odt = <LP4_CA_ODT_40ohm>;
> -		rockchip,phy_lpddr4_ca_drv = <PHY_DRV_ODT_40>;
> -		rockchip,phy_lpddr4_ck_cs_drv = <PHY_DRV_ODT_80>;
> -		rockchip,phy_lpddr4_dq_drv = <PHY_DRV_ODT_80>;
> -		rockchip,phy_lpddr4_odt = <PHY_DRV_ODT_60>;
> +		rockchip,lpddr4_drv = <60>;
> +		rockchip,lpddr4_dq_odt = <40>;
> +		rockchip,lpddr4_ca_odt = <40>;
> +		rockchip,phy_lpddr4_ca_drv = <40>;
> +		rockchip,phy_lpddr4_ck_cs_drv = <80>;
> +		rockchip,phy_lpddr4_dq_drv = <80>;
> +		rockchip,phy_lpddr4_odt = <60>;
>  	};
> 

Applied it with following minor fixup (unneeded spaces). Thanks


diff --git a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
index ddde2c4f97df..ac189dd82b08 100644
--- a/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
+++ b/Documentation/devicetree/bindings/devfreq/rk3399_dmc.txt
@@ -154,7 +154,7 @@ Following properties relate to DDR timing:
                                  driver strength. Default value is 80.
 
 - rockchip,phy_lpddr4_odt :      When the DRAM type is LPDDR4, this parameter defines
-                                 the PHY side ODT strength. Default value is 60.  
+                                 the PHY side ODT strength. Default value is 60.
 

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics