Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <77085577-01EB-48F5-868B-E7A1813363A1@oracle.com>
References: <77085577-01EB-48F5-868B-E7A1813363A1@oracle.com> <20210304175030.184131-1-eric.snowberg@oracle.com> <147604.1614981032@warthog.procyon.org.uk>
To:     Eric Snowberg <eric.snowberg@oracle.com>
Cc:     dhowells@redhat.com, Randy Dunlap <rdunlap@infradead.org>,
        Jarkko Sakkinen <jarkko@kernel.org>, nathan@kernel.org,
        David Woodhouse <dwmw2@infradead.org>,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] certs: Fix wrong kconfig option used for x509_revocation_list
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date:   Tue, 09 Mar 2021 11:46:21 +0000
Message-ID: <157933.1615290381@warthog.procyon.org.uk>
Precedence: bulk

Eric Snowberg <eric.snowberg@oracle.com> wrote:

> >> @@ -11,7 +11,7 @@ hostprogs-always-$(CONFIG_ASN1)				+=3D asn1_compiler
> >> hostprogs-always-$(CONFIG_MODULE_SIG_FORMAT)		+=3D sign-file
> >> hostprogs-always-$(CONFIG_SYSTEM_TRUSTED_KEYRING)	+=3D extract-cert
> >> hostprogs-always-$(CONFIG_SYSTEM_EXTRA_CERTIFICATE)	+=3D insert-sys-ce=
rt
> >> - hostprogs-always-$(CONFIG_SYSTEM_BLACKLIST_KEYRING)	+=3D extract-cert
> >> +hostprogs-always-$(CONFIG_SYSTEM_REVOCATION_LIST)	+=3D extract-cert
> >=20
> > Hmmm...  We have extract-cert listed twice.  Does that matter, I wonder?
>=20
> Isn=E2=80=99t this necessary, since one could build with either=20
> CONFIG_SYSTEM_REVOCATION_LIST or CONFIG_SYSTEM_TRUSTED_KEYRING, without=20
> the other being defined?

Well, it could be handled with its own Kconfig, say CONFIG_BUILD_EXTRACT_CE=
RT,
but that would seem like overkill.  I think make should handle a dependency
being listed multiple times for a target, but it might make sense to list t=
hem
next to each other.

David