Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1615270520-16951-1-git-send-email-dillon.minfei@gmail.com> <1615270520-16951-2-git-send-email-dillon.minfei@gmail.com>
In-Reply-To: <1615270520-16951-2-git-send-email-dillon.minfei@gmail.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 9 Mar 2021 09:01:40 -0300
Message-ID: <CAOMZO5CUekq_NSCag=fhGrNuxvt_E335Z+qYWCHi8sP8zKJgXg@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: imx6ull: fix ubi filesystem mount failed
To:     dillon.minfei@gmail.com
Cc:     Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Parthiban Nallathambi <parthiban@linumiz.com>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Dillon,

On Tue, Mar 9, 2021 at 3:15 AM <dillon.minfei@gmail.com> wrote:
>
> From: dillon min <dillon.minfei@gmail.com>
>
> since Micron MT29F2G08ABAEAWP's ecc error management:
>
> |Description                            | Requirement
> |Minimum required ECC                   | 4-bit ECC per 528 bytes
> |Minimum ECC with internal ECC enabled  | 4-bit ECC per 516 bytes (user data) +
>                                          8bytes (parity data)
>
> to avoid unnecessary overheads related to bigger ecc calculations.
> need choose to use fsl,use-minimum-ecc, else will run into ecc error.
>
> [    9.449265] ubi0: scanning is finished
> [    9.463968] ubi0 warning: ubi_io_read: error -74 (ECC error) while reading
> 22528 bytes from PEB 513:4096, read only 22528 bytes, retry
> [    9.486940] ubi0 warning: ubi_io_read: error -74 (ECC error) while reading
> 22528 bytes from PEB 513:4096, read only 22528 bytes, retry
> [    9.509906] ubi0 warning: ubi_io_read: error -74 (ECC error) while reading
> 22528 bytes from PEB 513:4096, read only 22528 bytes, retry
> [    9.532845] ubi0 error: ubi_io_read: error -74 (ECC error) while reading
> 22528 bytes from PEB 513:4096, read 22528 bytes
>
> Fixes: f9ecf10cb88c ("ARM: dts: imx6ull: add MYiR MYS-6ULX SBC")
> Signed-off-by: dillon min <dillon.minfei@gmail.com>

Reviewed-by: Fabio Estevam <festevam@gmail.com>