Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 9 Mar 2021 13:18:36 +0100
From:   Sascha Hauer <s.hauer@pengutronix.de>
To:     dillon.minfei@gmail.com
Cc:     robh+dt@kernel.org, shawnguo@kernel.org, parthiban@linumiz.com,
        kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com,
        devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6ull: fix ubi mount failed on MYS-6ULX-IOT
 board
Message-ID: <20210309121836.GU4207@pengutronix.de>
References: <1615270520-16951-1-git-send-email-dillon.minfei@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1615270520-16951-1-git-send-email-dillon.minfei@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Tue, Mar 09, 2021 at 02:15:19PM +0800, dillon.minfei@gmail.com wrote:
> From: dillon min <dillon.minfei@gmail.com>
> 
> This patch intend to fix ubi filesystem mount failed on MYS-6ULX-IOT board,
> from Micron MT29F2G08ABAEAWP's datasheets, we need to choose 4-bit ECC.
> 
> Table 18: Error Management Details
> 
> Description					Requirement
> 
> Minimum number of valid blocks (NVB) per LUN	2008
> Total available blocks per LUN			2048
> First spare area location			x8: byte 2048 x16: word 1024
> Bad-block mark					x8: 00h x16: 0000h
> Minimum required ECC				4-bit ECC per 528 bytes
> Minimum ECC with internal ECC enabled		4-bit ECC per 516 bytes (user data) + 8
> 						bytes (parity data)
> Minimum required ECC for block 0 if PROGRAM/
> ERASE cycles are less than 1000			1-bit ECC per 528 bytes

4-bit ECC is the minimum this chip requires. There's nothing wrong with
choosing a better ECC like the GPMI driver does by default.

It looks like you are papering over some other problem.

Sascha

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |