Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH resend v1 2/7] pps: clients: gpio: Use dev_err_probe() to
 avoid log noise
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-kernel@vger.kernel.org
Cc:     Ryan Govostes <rgovostes@whoi.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20210309112403.36633-1-andriy.shevchenko@linux.intel.com>
 <20210309112403.36633-2-andriy.shevchenko@linux.intel.com>
From:   Rodolfo Giometti <giometti@enneenne.com>
Message-ID: <e22021ef-28b7-54ad-91e8-7a4bac0b878b@enneenne.com>
Date:   Tue, 9 Mar 2021 13:25:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210309112403.36633-2-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/03/21 12:23, Andy Shevchenko wrote:
> When GPIO APIs return -EPROBE_DEFER there is no need to print the message,
> especially taking into consideration that it may repeat several times.
> Use dev_err_probe() to avoid log noise in such cases.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/pps/clients/pps-gpio.c | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index f89c31aa66f1..78c9680e8063 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -110,19 +110,16 @@ static int pps_gpio_setup(struct platform_device *pdev)
>  	data->gpio_pin = devm_gpiod_get(&pdev->dev,
>  		NULL,	/* request "gpios" */
>  		GPIOD_IN);
> -	if (IS_ERR(data->gpio_pin)) {
> -		dev_err(&pdev->dev,
> -			"failed to request PPS GPIO\n");
> -		return PTR_ERR(data->gpio_pin);
> -	}
> +	if (IS_ERR(data->gpio_pin))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(data->gpio_pin),
> +				     "failed to request PPS GPIO\n");
>  
>  	data->echo_pin = devm_gpiod_get_optional(&pdev->dev,
>  			"echo",
>  			GPIOD_OUT_LOW);
> -	if (IS_ERR(data->echo_pin)) {
> -		dev_err(&pdev->dev, "failed to request ECHO GPIO\n");
> -		return PTR_ERR(data->echo_pin);
> -	}
> +	if (IS_ERR(data->echo_pin))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(data->echo_pin),
> +				     "failed to request ECHO GPIO\n");
>  
>  	if (data->echo_pin) {
>  		ret = of_property_read_u32(np,
> 

Acked-by: Rodolfo Giometti <giometti@enneenne.com>

-- 
GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti