Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2550673pxb; Tue, 9 Mar 2021 05:33:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJzxHAB2bJ3Vx4X4/nDo/6b3zxqCPYQ707VZpFrljO67c5wYUnfjnK9c1mrStqz/iGmRATiN X-Received: by 2002:a17:906:5902:: with SMTP id h2mr20137448ejq.416.1615296810712; Tue, 09 Mar 2021 05:33:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615296810; cv=none; d=google.com; s=arc-20160816; b=IpUwNAVcoNp6722kbOseACWVZvPi4UrpKSeAvTVkbuJhXp7p8rRog+KHO5fKciInlL zxiGD7SVUVpyEG8RfczWHBq1Rhjs+wrUdfwK2Mvsw3P9hwzjB1xGarX5Vkxe0C5KRSWm sZinz/5nO/gpczIXFvckrZ9CUHQL18o6AzrjB1n7tPJWvJaPo9WWUEc8/KJoLEA3Z8rD XMuDIH7L4FCnBDhNYTOumE8FUu91Qj5hHgazCT/BMfFvv/wO0HdqCmd6k0Z/LgrmHndy 1z2rQptmrbBTtM0Z8OHnzF3pwjjoSDwDYCU7TS1KlFGImDwYra53dumoIndBouDcOxLf 98xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=DyG9tsfppZ03lD/Lsdb61Vn3isZGeZ0Tr3beWovxaIk=; b=LdIQTjqlN3aD1MK6gfoKxFu/rOIWWeGc+fppgdl4ccRhyQKYs07ng0vrA1ln+oMN1O 3KtrOQcJvzSEsiN5oHAHzJ2mEPYcTDnrmmfmHHKyvDIL51WjZkJirYATBa2Fw8mlZe9Q Gj4pA/Rwj74wrObgGL+52A22Zt3CiVxUExSKsGzT/v07Ii8D3Ey64UJbE1DHRCo2hjRq Y2hKCa7I/x11BFo9jJ0lfAXwK5pjiv6pn5bypzB3RBKNqx+61OuLguW5XPbNN8pYIFCh BLrNzTb5IWVRmD62Yrj/5sU3Mi4GXYQTvrWRaQRbKTnr0GpvsQhd0j9KHyXVgpl6ZH4Y If6Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AfQRSQar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 40si8823601edq.26.2021.03.09.05.33.07; Tue, 09 Mar 2021 05:33:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=AfQRSQar; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231422AbhCINcN (ORCPT + 99 others); Tue, 9 Mar 2021 08:32:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230473AbhCINbk (ORCPT ); Tue, 9 Mar 2021 08:31:40 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D6C9C06175F for ; Tue, 9 Mar 2021 05:31:40 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id n9so7814275pgi.7 for ; Tue, 09 Mar 2021 05:31:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DyG9tsfppZ03lD/Lsdb61Vn3isZGeZ0Tr3beWovxaIk=; b=AfQRSQarS5Z52+hfWM0kpU4IAa22xv3pg5hjILoTY60722wMV6cpmr7VwrO6Giujfu 5uKnSty3e+d8uHkUERddX0mRCmaOL5yQDZXE9CFGW+uZRIrEXblYE5H6ncL9gVexd04a qKnvOOQ4rZXAO9olhe4iUrmlvgCLhCL9xkjqc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DyG9tsfppZ03lD/Lsdb61Vn3isZGeZ0Tr3beWovxaIk=; b=GK3FUeO4tOppOte1vljWB/5PRdwPD4HEII7yfF9FFqkvSdRKgqMA6xoL2cHd3DFLsG Yo23Zhgs2Vs6OyzrhA3xGyjA8xaURUevDSQtFnYy8VN2xAgssEN+IDOdJoFszzAcRvTO xWFB361SeHclaI66rBI/W+qH/vcj1dP1UPZolHWG+zM7w/PHfklzuLaJfAY66z4MFvq4 M3/v2eZ9r3oI5GCCdxFJrBreZHbosjU6WnwefzF7/5ykdYRahchcxFCs25IoqyAnDzBt cTR22SW8maXqbL32O8XWPX7Va4Yktyncdpg0HUek5cjZi7riRVmR7hMz0I/ZwXb0WlGm T7uw== X-Gm-Message-State: AOAM533ZerUHyycpc6OH89my2XNpjMxMoWwj56J0hTlv0vDbq4nixxmv RI9826/3gCd5xhTt0PFoeVDH+A== X-Received: by 2002:a65:6493:: with SMTP id e19mr24396789pgv.239.1615296699783; Tue, 09 Mar 2021 05:31:39 -0800 (PST) Received: from hsinyi-z840.tpe.corp.google.com ([2401:fa00:1:10:f936:57e5:154d:e0d9]) by smtp.gmail.com with ESMTPSA id 138sm13678649pfv.192.2021.03.09.05.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Mar 2021 05:31:39 -0800 (PST) From: Hsin-Yi Wang To: Wolfram Sang , Bartosz Golaszewski , linux-i2c@vger.kernel.org, Mark Brown Cc: Matthias Brugger , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Bibby Hsieh , Rob Herring , Marek Szyprowski Subject: [PATCH v17 1/3] i2c: core: support bus regulator controlling in adapter Date: Tue, 9 Mar 2021 21:31:29 +0800 Message-Id: <20210309133131.1585838-2-hsinyi@chromium.org> X-Mailer: git-send-email 2.30.1.766.gb4fecdf3b7-goog In-Reply-To: <20210309133131.1585838-1-hsinyi@chromium.org> References: <20210309133131.1585838-1-hsinyi@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Bibby Hsieh Although in the most platforms, the bus power of i2c are alway on, some platforms disable the i2c bus power in order to meet low power request. We can control bulk regulator if it is provided in i2c adapter device. Signed-off-by: Bibby Hsieh Signed-off-by: Marek Szyprowski Signed-off-by: Hsin-Yi Wang --- drivers/i2c/i2c-core-base.c | 88 +++++++++++++++++++++++++++++++++++++ include/linux/i2c.h | 2 + 2 files changed, 90 insertions(+) diff --git a/drivers/i2c/i2c-core-base.c b/drivers/i2c/i2c-core-base.c index 63ebf722a424..436e498528a8 100644 --- a/drivers/i2c/i2c-core-base.c +++ b/drivers/i2c/i2c-core-base.c @@ -439,12 +439,14 @@ static int i2c_smbus_host_notify_to_irq(const struct i2c_client *client) static int i2c_device_probe(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); + struct i2c_adapter *adap; struct i2c_driver *driver; int status; if (!client) return 0; + adap = client->adapter; client->irq = client->init_irq; if (!client->irq) { @@ -510,6 +512,14 @@ static int i2c_device_probe(struct device *dev) dev_dbg(dev, "probe\n"); + if (adap->bus_regulator) { + status = regulator_enable(adap->bus_regulator); + if (status < 0) { + dev_err(&adap->dev, "Failed to enable bus regulator\n"); + goto err_clear_wakeup_irq; + } + } + status = of_clk_set_defaults(dev->of_node, false); if (status < 0) goto err_clear_wakeup_irq; @@ -550,8 +560,10 @@ static int i2c_device_probe(struct device *dev) static int i2c_device_remove(struct device *dev) { struct i2c_client *client = to_i2c_client(dev); + struct i2c_adapter *adap; struct i2c_driver *driver; + adap = client->adapter; driver = to_i2c_driver(dev->driver); if (driver->remove) { int status; @@ -564,6 +576,8 @@ static int i2c_device_remove(struct device *dev) } dev_pm_domain_detach(&client->dev, true); + if (!pm_runtime_status_suspended(&client->dev) && adap->bus_regulator) + regulator_disable(adap->bus_regulator); dev_pm_clear_wake_irq(&client->dev); device_init_wakeup(&client->dev, false); @@ -576,6 +590,79 @@ static int i2c_device_remove(struct device *dev) return 0; } +#ifdef CONFIG_PM_SLEEP +static int i2c_resume_early(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client || !client->adapter->bus_regulator) + return 0; + + if (!pm_runtime_status_suspended(&client->dev)) { + err = regulator_enable(client->adapter->bus_regulator); + if (err) + return err; + } + + return pm_generic_resume_early(&client->dev); +} + +static int i2c_suspend_late(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client || !client->adapter->bus_regulator) + return 0; + + err = pm_generic_suspend_late(&client->dev); + if (err) + return err; + + if (!pm_runtime_status_suspended(&client->dev)) + return regulator_disable(client->adapter->bus_regulator); + + return 0; +} +#endif + +#ifdef CONFIG_PM +static int i2c_runtime_resume(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client || !client->adapter->bus_regulator) + return 0; + + err = regulator_enable(client->adapter->bus_regulator); + if (err) + return err; + return pm_generic_runtime_resume(&client->dev); +} + +static int i2c_runtime_suspend(struct device *dev) +{ + struct i2c_client *client = i2c_verify_client(dev); + int err; + + if (!client || !client->adapter->bus_regulator) + return 0; + + err = pm_generic_runtime_suspend(&client->dev); + if (err) + return err; + + return regulator_disable(client->adapter->bus_regulator); +} +#endif + +static const struct dev_pm_ops i2c_device_pm = { + SET_LATE_SYSTEM_SLEEP_PM_OPS(i2c_suspend_late, i2c_resume_early) + SET_RUNTIME_PM_OPS(i2c_runtime_suspend, i2c_runtime_resume, NULL) +}; + static void i2c_device_shutdown(struct device *dev) { struct i2c_client *client = i2c_verify_client(dev); @@ -633,6 +720,7 @@ struct bus_type i2c_bus_type = { .probe = i2c_device_probe, .remove = i2c_device_remove, .shutdown = i2c_device_shutdown, + .pm = &i2c_device_pm, }; EXPORT_SYMBOL_GPL(i2c_bus_type); diff --git a/include/linux/i2c.h b/include/linux/i2c.h index 56622658b215..ec87758d9f40 100644 --- a/include/linux/i2c.h +++ b/include/linux/i2c.h @@ -15,6 +15,7 @@ #include /* for struct device */ #include /* for completion */ #include +#include #include #include /* for Host Notify IRQ */ #include /* for struct device_node */ @@ -721,6 +722,7 @@ struct i2c_adapter { const struct i2c_adapter_quirks *quirks; struct irq_domain *host_notify_domain; + struct regulator *bus_regulator; }; #define to_i2c_adapter(d) container_of(d, struct i2c_adapter, dev) -- 2.30.1.766.gb4fecdf3b7-goog