Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2597999pxb; Tue, 9 Mar 2021 06:33:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJx31vyzYefpyHQfD2kiWzmpE5gw9KZOha/qnpmZozxpmpp6aHhOwMVIvfcwh/8PSwJySwHX X-Received: by 2002:a17:907:b06:: with SMTP id h6mr20543205ejl.144.1615300420908; Tue, 09 Mar 2021 06:33:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615300420; cv=none; d=google.com; s=arc-20160816; b=XiTIdwqJDNIWh/5g/RTxYzFQxDHy07ETY/wr7DLQ+WlmNoFK6rVrzPt482beVbWJME iL12gBwiqzjGosRAkFzVZn3LVeIetmItUn3O7DSSi7lp4iZTvSMW5jVAxyMTYvpihOnQ e6XPXILHGCWMAs0uueVUWdnS4nmVd83DwexOWeN5F90Dvm6P7zBRiHWORxst7gas1Iza 8eN2J2JCftXHIU6o9V1I8QNHqshdQjizwsZZn+8L4JR4ncIF+vQWcYQ4XA30av6bFKw1 lAzgY/Q5SKKF7gbIMXGuvUu1NfAp+8n/FwO6J0gFDdEGXDIY+tbUwQnJKuoisx7f5b5e moiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=4yMmDfex6l/3uuKHORT/h+heZ1g31xJwUPhoiGfiMXU=; b=vZ0hd1vvvai2IV7H6FZtoPXioGsAeRXp8me6XXpn211xz4SPyLe8usoB6AebuFv29I ooKYGzwlVKHzUH8fkxuzJPWsKhJDqqKOcbrEzpknAlAgLBOWIrBMCct6fMvC4OTtVj+f Pan7o/xBTSf4tF1Ps9FSTSpUxEp/XFN0ColAi8EENFufD7cNOoZ2ns5IztwvdH9+u68U aQrUdljGab6ATKys35FHkmiQTOTkJXuHbV9IHkd4uDGQSfPNj1GPM60ht+1KBXIORk9/ XM1BbWPjxhR812q5tyacfMiBFhm+gcFQWuOiQtWqx9Giza5+rSmhCvziOkKqN1IW+4zk W12A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="o/B6zf5F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q2si10335626edb.393.2021.03.09.06.33.17; Tue, 09 Mar 2021 06:33:40 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b="o/B6zf5F"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231418AbhCIOcT (ORCPT + 99 others); Tue, 9 Mar 2021 09:32:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhCIObs (ORCPT ); Tue, 9 Mar 2021 09:31:48 -0500 Received: from mail.skyhub.de (mail.skyhub.de [IPv6:2a01:4f8:190:11c2::b:1457]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6DD6C06174A; Tue, 9 Mar 2021 06:31:47 -0800 (PST) Received: from zn.tnic (p200300ec2f0d1e00ce22ef39451b66b4.dip0.t-ipconnect.de [IPv6:2003:ec:2f0d:1e00:ce22:ef39:451b:66b4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 43D5A1EC0258; Tue, 9 Mar 2021 15:31:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1615300306; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=4yMmDfex6l/3uuKHORT/h+heZ1g31xJwUPhoiGfiMXU=; b=o/B6zf5F47HzYEdAj4BQZZE1lthxUvFBAXglcCXUnDfHLCL1mnAk85g0hb/uWwLhxKJrx6 aPbZGoSPgBVXsIt9dUx/VkgK2Q7EahqT2sSFGqz3yJk/trsX5b8F7SR5EtZ5DDP8TZkYCP 7DhwJ3LMYUUyfEnymktu364C8jp4ApU= Date: Tue, 9 Mar 2021 15:31:41 +0100 From: Borislav Petkov To: "Yu, Yu-cheng" Cc: linux-man@vger.kernel.org, Alejandro Colomar , Michael Kerrisk , Andy Lutomirski , Dave Hansen , Florian Weimer , "H.J. Lu" , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org Subject: Re: [PATCH 2/2] sigaction.2: wfix - Clarify si_addr description. Message-ID: <20210309143141.GD699@zn.tnic> References: <20210226172634.26905-1-yu-cheng.yu@intel.com> <20210226172634.26905-3-yu-cheng.yu@intel.com> <20210308212936.GD12548@zn.tnic> <40c3c4cc-e135-1355-51ee-4d0f16e47e71@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <40c3c4cc-e135-1355-51ee-4d0f16e47e71@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 08, 2021 at 01:46:07PM -0800, Yu, Yu-cheng wrote: > I think the sentence above is vague, but probably for the reason that each > arch is different. Maybe this patch is unnecessary and can be dropped? Maybe. If you want to clarify it, you should audit every arch. But what would that bring? IOW, is it that important to specify when si_addr is populated and when not...? I don't know of an example but I'm no userspace programmer anyway, to know when this info would be beneficial... -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette