Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com>
 <1615294733-22761-3-git-send-email-aisheng.dong@nxp.com> <c5f27c46-f1a0-cd19-3bec-3dd8800b2cae@gmail.com>
In-Reply-To: <c5f27c46-f1a0-cd19-3bec-3dd8800b2cae@gmail.com>
From:   Dong Aisheng <dongas86@gmail.com>
Date:   Tue, 9 Mar 2021 23:14:39 +0800
Message-ID: <CAA+hA=RTEZq68opa4N1SZB-uo__+8PkN9HTBa1+scODBQPFtiw@mail.gmail.com>
Subject: Re: [PATCH 02/11] PM / devfreq: remove the invalid description for get_target_freq
To:     Chanwoo Choi <cwchoi00@gmail.com>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        open list <linux-kernel@vger.kernel.org>,
        myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Abel Vesa <abel.vesa@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 9, 2021 at 11:02 PM Chanwoo Choi <cwchoi00@gmail.com> wrote:
>
> On 21. 3. 9. =EC=98=A4=ED=9B=84 9:58, Dong Aisheng wrote:
> > First of all, no_central_polling was removed since
> > commit 7e6fdd4bad03 ("PM / devfreq: Core updates to support devices
> > which can idle")
> > Secondly, get_target_freq() is not only called only with update_devfreq=
()
> > notified by OPP now, but also min/max freq qos notifier.
> >
> > So remove this invalid description now to avoid confusing.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >   drivers/devfreq/governor.h | 2 --
> >   1 file changed, 2 deletions(-)
> >
> > diff --git a/drivers/devfreq/governor.h b/drivers/devfreq/governor.h
> > index 70f44b3ca42e..5cee3f64fe2b 100644
> > --- a/drivers/devfreq/governor.h
> > +++ b/drivers/devfreq/governor.h
> > @@ -57,8 +57,6 @@
> >    *                  Basically, get_target_freq will run
> >    *                  devfreq_dev_profile.get_dev_status() to get the
> >    *                  status of the device (load =3D busy_time / total_=
time).
> > - *                   If no_central_polling is set, this callback is ca=
lled
> > - *                   only with update_devfreq() notified by OPP.
> >    * @event_handler:      Callback for devfreq core framework to notify=
 events
> >    *                      to governors. Events include per device gover=
nor
> >    *                      init and exit, opp changes out of devfreq, su=
spend
> >
>
> As I replied from patch1, I recommend that squash it with patch1.

Got it, i will squash when sending the next version.
Thanks

Regards
Aisheng

>
> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi