Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2645341pxb; Tue, 9 Mar 2021 07:34:23 -0800 (PST) X-Google-Smtp-Source: ABdhPJxudIVncM+IAX8fvX0A/oBAEoZmZiA5TYi/p5VZsTtUN50Vc867Qog246Kpr25B2G7+3VOd X-Received: by 2002:aa7:c386:: with SMTP id k6mr4691134edq.224.1615304063307; Tue, 09 Mar 2021 07:34:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615304063; cv=none; d=google.com; s=arc-20160816; b=CTW934oe9stzaLkxj3liYzFdFoF2aH7v3xgfEyNuBbUuORL/gvTUir3pVAprRR1Lh2 qPA0RCVN8wjiLQV+4SEJY/p9dNxLFXk6nsBN5kC3Ux3dcxahG7tpjyxaD/OVqs7LLezl Xe6yo9teEdoMV4qpH5ADP/6+GOZCfEFyEvD9Xk73tGl3k/FlnHPN6+4TE8dhjlvDKf4n /vSoaBn/vKNHj2UrgH/KxtFneptxIg0IfN1DGunaxyqvgf38S8Hkf+mJpSW0NLPCiCpa DKmoFubIG7cH5si6w7uo9SLkoZxklGwwlAYyTxBqg/K1GfMkh8dCXPz7NnEStBkXRB+5 dYuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=ytPSd3A3o1b3+2MlI23BkWVwBk2Qohz+v6T0uxCz9RU=; b=JduXWrsMGpnDly5/ZorvpsU4ydXa2Ir493WUSNE24klBaBfCOEl75hheIG5hfUAzGH FSA3GU9z7LfuK1LsLgdGVlqTAyL6Q6JpHpMIH87T1uaXZfza2aTlbhwY1YoYNmSPAhBQ rOmqYa9yQX7pJdm/xv6/SI9SEyvAOoSM5lgKe0OcFRrdKJ0NOTjSP5muj7F2S83No0eX kahaDlgpTmxDjwcZgS3tbuU8hi3sz8pVIyMj0TQvzUnhZ43DYAyzff8HivRDw4VxwEoO 9pHcSapzlIrYXj5bsoetYVf+Xr8Ol+f/ATH5xvnUHoTCbagCB0S8Z0v3cdK/1FZOmSRT sUyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZsDiIRRw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i21si9482781ejv.334.2021.03.09.07.34.00; Tue, 09 Mar 2021 07:34:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ZsDiIRRw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231878AbhCIPcY (ORCPT + 99 others); Tue, 9 Mar 2021 10:32:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231673AbhCIPbw (ORCPT ); Tue, 9 Mar 2021 10:31:52 -0500 Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27BA3C06175F for ; Tue, 9 Mar 2021 07:31:52 -0800 (PST) Received: by mail-lf1-x130.google.com with SMTP id u4so27772571lfs.0 for ; Tue, 09 Mar 2021 07:31:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ytPSd3A3o1b3+2MlI23BkWVwBk2Qohz+v6T0uxCz9RU=; b=ZsDiIRRw+LQemQRHuo0zPr0x7lYYY1RnmWzkwLTDWTgoiy/WPSeXg/JaqaTrpgMG3q ikEXZC1G7CHl5BS1bfjXkICij2hiQ6WpSSM+Metl62wF5PagNLwgLpOJJ0GyWXw+7Mq0 yZGh8DBCJF4pOgqHWr5Fwp+ga3e5eloGHFvzTJjeok0tMOwbfseR1tixEGwIuy/E2mEO REWCX0BsJOOBHq5W1AlXu+5NKi0y/LPYDmdZ4KJZ4sYnjc9oO3tmpALL7C4AQpar3ng8 5dVI2dneZPzIGcGroTAYeGXc8nPkUdXN4CCe30O7y30/+9hokigEsxJTr7Vkhw7VftM8 RYSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ytPSd3A3o1b3+2MlI23BkWVwBk2Qohz+v6T0uxCz9RU=; b=VaJJtLLKPkf0Apin5yLviYw+VH4IS/eykDuY1zsqLWVOEUMxemWZxE+B7QPOfotuGC DjLApkphjrA03WSif7Uxe9J8VeIpY3WAD6SBXfM77pGDYcKHhy3OXmfEWkX6eGgi/ANa AHLbeVz0KxTQ3rONsODjRd6lFJzYLJT10HZyxtdTkwfJGaAU8BKgAM6CJ1S6qMjMbVEm jn/UfK3nKU9S/a8ZVKIxgpv+cYbrvDc/Xu6AcvRscwwCUBb+VR4zbKjcUgLKgcVFqzUG Zv6xcbDGSCdoA76ur0+PkxDSFMi1XxFLM1BXO3wWHBGBbyf1Qtp0uM/CGptvJcK6W86x uK/Q== X-Gm-Message-State: AOAM533VDdcFVennmbM6ffRS/eCvrTx/iKXrG1mwlJw6waQhImUD/tec iUywWXpbUP8bKHFjqFzL6spltJa7zwORvyb9TPqYmA== X-Received: by 2002:a05:6512:10d1:: with SMTP id k17mr17314789lfg.649.1615303910617; Tue, 09 Mar 2021 07:31:50 -0800 (PST) MIME-Version: 1.0 References: <20210309093736.67925-1-andriy.shevchenko@linux.intel.com> <20210309093736.67925-7-andriy.shevchenko@linux.intel.com> In-Reply-To: <20210309093736.67925-7-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Tue, 9 Mar 2021 16:31:39 +0100 Message-ID: Subject: Re: [PATCH v6 6/6] gpiolib: Fold conditionals into a simple ternary operator To: Andy Shevchenko Cc: Mika Westerberg , Linux Doc Mailing List , "linux-kernel@vger.kernel.org" , "open list:GPIO SUBSYSTEM" , ACPI Devel Maling List , Marc Zyngier , Jonathan Corbet , Bartosz Golaszewski , Thomas Gleixner , "Rafael J. Wysocki" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 9, 2021 at 10:37 AM Andy Shevchenko wrote: > It's quite spread code to initialize IRQ domain options. > Let's fold it into a simple oneliner. > > Signed-off-by: Andy Shevchenko Definitely due to my coding style. (Not so fond of the ternary operator.) Allright, it is so much more compact. Reviewed-by: Linus Walleij Yours, Linus Walleij