Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: GW0EPtWTJBPmRBpKJIXo9Gu0lhHO3irB7a8Yw7ZlbgNT5bjosdyIEO7RY4nBykQzYJkIRjGpWA
 TaNMRqAg5hVA==
IronPort-SDR: +i6VdVFC9GL00rPRtx/bSqZoPfXP6nEUAghQhRFtwTYUrFxfvcOMYzi+up9usmYI31CNX1xyJE
 VmqM3HnIfwRw==
Message-ID: <69475ef69096587be23f632e79efce5711c82cf1.camel@linux.intel.com>
Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state
 bit during suspend/resume
From:   Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To:     "Ye, Xiang" <xiang.ye@intel.com>, Jiri Kosina <jikos@kernel.org>
Cc:     jic23@kernel.org, linux-input@vger.kernel.org,
        linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Tue, 09 Mar 2021 08:08:36 -0800
In-Reply-To: <20210309034742.GA18299@host>
References: <20210303062825.7724-1-xiang.ye@intel.com>
         <nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm>
         <00ad0906b90a290e9737b7bf7d8c5ab9c6ed61e6.camel@linux.intel.com>
         <20210309034742.GA18299@host>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote:
> Hi Srinivas, Jiri
> 
> On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote:
> > On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote:
> > > On Wed, 3 Mar 2021, Ye Xiang wrote:
> > > 
> > > > ISH firmware uses connected standby state bit
> > > > (CONNECTED_STANDBY_STATE_BIT bit 1)
> > > > to notify current power state to sensors instead of suspend
> > > > state
> > > > bit (bit 0).
> > > > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT
> > > > to
> > > > firmware
> > > > to be compatible with the previous version.
> > > 
> > > Could you please make the changelog more verbose -- namely what 
> > > user-visible issue this is fixing?
> > Xiang,
> > 
> > I think this change is for related to Elkhart Lake for support of
> > connected standby (keep listening for sensor events during Linux
> > suspend for some sensors). In this way some sensor can wake up the
> > system.
> This change is for all ISH platform. Currently, ISH firmware use
> both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to identify
> system state. It is related to system wake up by ISH and it enable
> each
> sensor in ISH to be notified the current system state, when system
> state
> change.
What will sensors do with this additional information?
I think the individual sensors in ISH can decide whether to power OFF
or ON based on this information to save power during system suspend to
idle.

Thanks,
Srinivas

> 
> Thanks
> Ye Xiang
> > 
> > 
> > 
> > 
> > 
> >