Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2682117pxb; Tue, 9 Mar 2021 08:23:14 -0800 (PST) X-Google-Smtp-Source: ABdhPJynvJYuC1f5GsFIwErscgApC+AldsBRTZXwNnYShWnq9IpCqT6afpxW+e+gcQVqX3u5gqki X-Received: by 2002:a17:906:ca50:: with SMTP id jx16mr21202949ejb.72.1615306994372; Tue, 09 Mar 2021 08:23:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615306994; cv=none; d=google.com; s=arc-20160816; b=Cf60fqRPIjG0CgqdomtDkzcFMMCWz5z/FxjbOnBu7EVzZiZA54m9/4MgmHCxtsktrd kWDLbdpqZkGIaUxtG3HtIBI06naySwDzLWqlB/G3Mc7V8iSZRTA9vdTIuKrmITO2maHT kM3gdrv7UVPiESp5ftTy5IobfCk9/PKgmsNnTqvU01LGJtgoay5WwBrJxXgEYMuJj/v1 CC/mgrWBBIEJaQKQ1MhZ/VhgjUlwInnoIxHVr9aqLCSl1/tRCur3Tfs51u6bpRy0c9H0 +SoOudW+6C6fVAtxVoAU2OF9RuS97wN9moMF+p1hxdaDwL66idyIO0J7h32HydRnvgQb DX6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=NdXOG6ljmNbXTOPX+64Dn7agKNrrC7wRclWk4pldd2Y=; b=gZrJxipEPPp32GFJ8fbY4qisSutD/sJ3bKM3TCGvOSubvUut6JzXUne439sd0qoqru BI+LtGi9h1J3hwh4o/2mvl8QdhlLlDZ7JPNItjQWx8Wg3oHQmHLxzRI/an8CEkHbhj1Y 06n8AZBRa6hTf73UxP6tjI15AqOvqA/SE0C3qFmyBQ9wy3LvjNUTMSL3TQxpDewXSCdf gi+0YrIfdr/TJ0//Q5RyGTtNNj7EyJHftDcHtA3pFRpF0Lz962goxBSp/BLPhyCS8aaS Jq3VW+E/jaSYns20PNJkzXG2yFKloxw8+YryYlIO4olL4NW2gpy2RgL/UMjdsTwifVuh YlYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bft3qeAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h23si9134802edw.60.2021.03.09.08.22.50; Tue, 09 Mar 2021 08:23:14 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=bft3qeAE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231146AbhCIQVP (ORCPT + 99 others); Tue, 9 Mar 2021 11:21:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231901AbhCIQU7 (ORCPT ); Tue, 9 Mar 2021 11:20:59 -0500 Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com [IPv6:2a00:1450:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 76EA0C061760 for ; Tue, 9 Mar 2021 08:20:58 -0800 (PST) Received: by mail-lj1-x22a.google.com with SMTP id m11so21364939lji.10 for ; Tue, 09 Mar 2021 08:20:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=NdXOG6ljmNbXTOPX+64Dn7agKNrrC7wRclWk4pldd2Y=; b=bft3qeAE0HV4abBfBNN7i/Jlucff/PRs0/gz+DAi0q8jM9HDngjw5PTq70PFqJO2cU 9COJjgpOU+cnTXssQT5aRrCnYcqOWzh4SFsKHgo0tFhj2AfNuro3Rbfe6sZywa6CJ54i 3ol4XrTE0EXS/Ole3GKZnLAbaroDSmYj93ArmU/QxnW5Ga4KskiA2PX95g61DiRKAUcR fcsWvxApQyJhjLeaWVxd38KtRHMPxA9Cku6ZV7BLG19R6fP2TbCPTJHwxKcyQq0JmU5a oWj5up5CIec5oV6hKdbmNsC9S/A+RLYwZcCVM+OhIaVuTgYY0etUiqpo68y793Lj2oko FBoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=NdXOG6ljmNbXTOPX+64Dn7agKNrrC7wRclWk4pldd2Y=; b=CggTCtVh+O88tb/+bC0dlDiMMjowt/Ti+w6CIFzqO8aY6dzC6BmAMhcGk77icOGNCU Y07IBYCt3CKwTte3//VxBdr13hlUUrRFV4ojRZxW9gGRQ+CaL5M5M8mxBRQ2qBxpqXRi g9gldaYDR+XgcTVvlWavw34j6n7xvi5GIw9X94Fi3UY4wNf5XD0K9SiuzhQWEATHTmBM Ml9Ix1zq+bt1EcRHKncZBpT+KYBZQIkuAiErVub5lAg0UjrQLQku2TO93B4Vs60CB4E9 tmjwBkF+g63FavrBFWpjKbFCdrOVcD7iF0q5Dae6sBLJVua0iohoYsTs1JPYlsJ2J3Ey lb8w== X-Gm-Message-State: AOAM5315qQR+GUBqft7dozkKM4/V8h1kJFBIg9tkhtb+F1TcWelGV2E4 zpXkdMuEXO8pIzNyDYQtfiXEawuQcqKcZiH99ele5Q== X-Received: by 2002:a2e:700a:: with SMTP id l10mr17590963ljc.368.1615306856856; Tue, 09 Mar 2021 08:20:56 -0800 (PST) MIME-Version: 1.0 References: <20210304085710.7128-1-noltari@gmail.com> <20210304085710.7128-2-noltari@gmail.com> In-Reply-To: <20210304085710.7128-2-noltari@gmail.com> From: Linus Walleij Date: Tue, 9 Mar 2021 17:20:45 +0100 Message-ID: Subject: Re: [PATCH v4 01/15] gpio: guard gpiochip_irqchip_add_domain() with GPIOLIB_IRQCHIP To: =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= Cc: Rob Herring , Michael Walle , Bartosz Golaszewski , Florian Fainelli , bcm-kernel-feedback-list , Jonas Gorski , Necip Fazil Yildiran , Andy Shevchenko , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 4, 2021 at 9:57 AM =C3=81lvaro Fern=C3=A1ndez Rojas wrote: > The current code doesn't check if GPIOLIB_IRQCHIP is enabled, which resul= ts in > a compilation error when trying to build gpio-regmap if CONFIG_GPIOLIB_IR= QCHIP > isn't enabled. > > Fixes: 6a45b0e2589f ("gpiolib: Introduce gpiochip_irqchip_add_domain()") > Signed-off-by: =C3=81lvaro Fern=C3=A1ndez Rojas Reviewed-by: Linus Walleij Yours, Linus Walleij