Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
To:     Christoph Lameter <cl@gentwo.de>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org, vbabka@suse.cz,
        penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com,
        corbet@lwn.net, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20210309134720.29052-1-georgi.djakov@linaro.org>
 <alpine.DEB.2.22.394.2103091554430.109061@gentwo.de>
From:   Georgi Djakov <georgi.djakov@linaro.org>
Subject: Re: [PATCH] mm/slub: Add slub_debug option to panic on memory
 corruption
Message-ID: <a712359c-4671-6f6e-13a1-2a9682a6ec08@linaro.org>
Date:   Tue, 9 Mar 2021 20:12:53 +0200
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.22.394.2103091554430.109061@gentwo.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Christoph,

Thanks for the comments!

On 3/9/21 16:56, Christoph Lameter wrote:
> On Tue, 9 Mar 2021, Georgi Djakov wrote:
> 
>> Being able to stop the system immediately when a memory corruption
>> is detected is crucial to finding the source of it. This is very
>> useful when the memory can be inspected with kdump or other tools.
> 
> Hmmm.... ok.

The idea is to be able to collect data right after the corruption is
detected, otherwise more data might be corrupted and tracing becomes
more difficult.

> 
>>   static void restore_bytes(struct kmem_cache *s, char *message, u8 data,
>>   						void *from, void *to)
>>   {
>> +	if (slub_debug & SLAB_CORRUPTION_PANIC)
>> +		panic("slab: object overwritten\n");
>>   	slab_fix(s, "Restoring 0x%p-0x%p=0x%x\n", from, to - 1, data);
>>   	memset(from, data, to - from);
>>   }
> 
> Why panic here? This should only be called late in the bug reporting when
> an error has already been printed.

This is called by both slab_pad_check() and check_bytes_and_report(), so it
seemed like a common place where i could put the panic(). I can move it to
the caller functions instead, if that's preferred.

Thanks,
Georgi