Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2772288pxb; Tue, 9 Mar 2021 10:24:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtV1vUJGUVIwO7YIc12+jNEHk5tZW1DrNQgc/BdMiSrOg6nt7h+FIyCOcAo3frvZkLDhfG X-Received: by 2002:aa7:d642:: with SMTP id v2mr5741504edr.257.1615314295416; Tue, 09 Mar 2021 10:24:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615314295; cv=none; d=google.com; s=arc-20160816; b=MgEe7EXi97tB+RYorPahfKMO5fTVL9ircLFveI0waOm61vK26FQS4Pmcy6LSrxOCnr LmHaMr8GzwIzWvFW/3KdMyED1Qnz8edaS04FTWnthj3U9+iqvu6CPuqWGcRVx8F9ugrQ Fny6T3tj76qD1J4GLcLWPgqVWYpKYAjBmwPVY7gLZHW8QhL1xirheAl9kgTlJBwBsRo2 qsN3mRcTDd2+9BkceavhIsb0FnouZn2h5obzDBoU3hPoPTi/AYigPSWoTwhpKV5uSMOt YVLI57s3yGSs5xU1OlCYhNEn+afpQWasvWy2mRYTp938o7AF3xKOhTvI0/ryyxWTllv9 i86Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ghIL96dAj+teO7QRVsuWgtcm+qr8fBxdtE412wvD4Ek=; b=qtEsHVh26Tef5SLLyioCWJsaejqpcCcUrPpUOl4Vq96pLJcZNdEUV9WgxY+tj+t+zW 6gr4gMdRc+m384CsFPfyj4KK5X9MmTnVD+nruTSZvYML6h9qXnX03+n1hNsBmbSvg1XU Cnt8FBbMjiIZXGKRO6y/S4Pufaa2Eat+Yne/K4ofEaQfDtB8gQ9zOF8NTu/k/Mnhj4lC xhaGKRRpjR8v1/Y6s3ULoDcfRkrQdDPxmL3Ok9KqBys6ouyfg3qip3oYG60jAkKa1+B8 gINjZseDoNXu31XyaBPH6GnelwyOIRV4adWDq8PUWk5GZ/erWlRkoD8vkqI86wSZEUDz VRdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@yandex-team.com header.s=default header.b=sTDWx4bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u4si9998287ejy.135.2021.03.09.10.24.31; Tue, 09 Mar 2021 10:24:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@yandex-team.com header.s=default header.b=sTDWx4bw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=yandex-team.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230516AbhCISXb (ORCPT + 99 others); Tue, 9 Mar 2021 13:23:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229815AbhCISXP (ORCPT ); Tue, 9 Mar 2021 13:23:15 -0500 Received: from forwardcorp1o.mail.yandex.net (forwardcorp1o.mail.yandex.net [IPv6:2a02:6b8:0:1a2d::193]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D56BC06174A; Tue, 9 Mar 2021 10:23:15 -0800 (PST) Received: from iva8-d077482f1536.qloud-c.yandex.net (iva8-d077482f1536.qloud-c.yandex.net [IPv6:2a02:6b8:c0c:2f26:0:640:d077:482f]) by forwardcorp1o.mail.yandex.net (Yandex) with ESMTP id 530DA2E15A0; Tue, 9 Mar 2021 21:23:10 +0300 (MSK) Received: from iva4-f06c35e68a0a.qloud-c.yandex.net (iva4-f06c35e68a0a.qloud-c.yandex.net [2a02:6b8:c0c:152e:0:640:f06c:35e6]) by iva8-d077482f1536.qloud-c.yandex.net (mxbackcorp/Yandex) with ESMTP id yuCti61pxa-N8J88Z6Q; Tue, 09 Mar 2021 21:23:10 +0300 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex-team.com; s=default; t=1615314190; bh=ghIL96dAj+teO7QRVsuWgtcm+qr8fBxdtE412wvD4Ek=; h=In-Reply-To:Message-Id:References:Date:Subject:To:From:Cc; b=sTDWx4bwgzAXwWWRXuisf9SyPxZzUts6Rgolz27d+htGGZluzVR4b2WDTIPTjh427 NiUR2gC0aFAQNjoomWKwzt+/l2IV89P8v2PwcFykiOYEMdCGSg7RIshDVj5X00ocIo rM7XIYCw+rXzWLb6pmZ1EssT7fWTEItGY8wo8vOk= Authentication-Results: iva8-d077482f1536.qloud-c.yandex.net; dkim=pass header.i=@yandex-team.com Received: from dynamic-vpn.dhcp.yndx.net (dynamic-vpn.dhcp.yndx.net [2a02:6b8:b081:203::1:15]) by iva4-f06c35e68a0a.qloud-c.yandex.net (smtpcorp/Yandex) with ESMTPSA id T5bJwzP5HK-N8nWRD8I; Tue, 09 Mar 2021 21:23:08 +0300 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client certificate not present) From: Andrey Ryabinin To: gregkh@linuxfoundation.org, stable@vger.kernel.org Cc: jroedel@suse.de, will@kernel.org, linux-kernel@vger.kernel.org, Andrey Ryabinin Subject: [PATCH stable 4.9] iommu/amd: Fix sleeping in atomic in increase_address_space() Date: Tue, 9 Mar 2021 21:24:28 +0300 Message-Id: <20210309182430.18849-2-arbn@yandex-team.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20210309182430.18849-1-arbn@yandex-team.com> References: <161512522533161@kroah.com> <20210309182430.18849-1-arbn@yandex-team.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org commit 140456f994195b568ecd7fc2287a34eadffef3ca upstream. increase_address_space() calls get_zeroed_page(gfp) under spin_lock with disabled interrupts. gfp flags passed to increase_address_space() may allow sleeping, so it comes to this: BUG: sleeping function called from invalid context at mm/page_alloc.c:4342 in_atomic(): 1, irqs_disabled(): 1, pid: 21555, name: epdcbbf1qnhbsd8 Call Trace: dump_stack+0x66/0x8b ___might_sleep+0xec/0x110 __alloc_pages_nodemask+0x104/0x300 get_zeroed_page+0x15/0x40 iommu_map_page+0xdd/0x3e0 amd_iommu_map+0x50/0x70 iommu_map+0x106/0x220 vfio_iommu_type1_ioctl+0x76e/0x950 [vfio_iommu_type1] do_vfs_ioctl+0xa3/0x6f0 ksys_ioctl+0x66/0x70 __x64_sys_ioctl+0x16/0x20 do_syscall_64+0x4e/0x100 entry_SYSCALL_64_after_hwframe+0x44/0xa9 Fix this by moving get_zeroed_page() out of spin_lock/unlock section. Fixes: 754265bcab ("iommu/amd: Fix race in increase_address_space()") Signed-off-by: Andrey Ryabinin Acked-by: Will Deacon Link: https://lore.kernel.org/r/20210217143004.19165-1-arbn@yandex-team.com Signed-off-by: Joerg Roedel Signed-off-by: Andrey Ryabinin --- drivers/iommu/amd_iommu.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c index f4a15d9f2bbb2..8377bd388d673 100644 --- a/drivers/iommu/amd_iommu.c +++ b/drivers/iommu/amd_iommu.c @@ -1331,24 +1331,26 @@ static void increase_address_space(struct protection_domain *domain, unsigned long flags; u64 *pte; + pte = (void *)get_zeroed_page(gfp); + if (!pte) + goto out; + spin_lock_irqsave(&domain->lock, flags); if (WARN_ON_ONCE(domain->mode == PAGE_MODE_6_LEVEL)) /* address space already 64 bit large */ goto out; - pte = (void *)get_zeroed_page(gfp); - if (!pte) - goto out; - *pte = PM_LEVEL_PDE(domain->mode, virt_to_phys(domain->pt_root)); domain->pt_root = pte; domain->mode += 1; domain->updated = true; + pte = NULL; out: spin_unlock_irqrestore(&domain->lock, flags); + free_page((unsigned long)pte); return; } -- 2.26.2