Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp2793136pxb; Tue, 9 Mar 2021 10:59:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJzC491heE3S8Pw5b3ZX1OsV4dQMayJ2ygQNoHb5MuMZCVYbs5T9GF0aoJOKUEgKqdqiAkvV X-Received: by 2002:aa7:c7c3:: with SMTP id o3mr5996232eds.8.1615316342530; Tue, 09 Mar 2021 10:59:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615316342; cv=none; d=google.com; s=arc-20160816; b=kpzWqzygBO1rSasKzGcVc8BY0K5vZMM4g0m3v5enaLaQy1IgSjmf0Ws582Waa00Na3 dgx/kRNkz/DS88QNhVcxNzXar2GfhpK4PKFq0jtBo+CzSF10vRRKa5a9TKc6wISZFHnq N3hrJajnHA1nfxz4kqCJNCU29/ngE/SW94B8IrYuIlcn932tRFixplIhT4N64g6arz4p 5+JVCwnz2dTOIrW5tPfSQXQ+o8bcgz+C3gTQRmC6EMiQj3Lj29//RDIkrD7Wx6v5l4c6 FXCWNzboukwEgATHkPK0S+Y8eUkWXhKVXAt2l7yy3UYfDD82pRcczQ8iBeyXYHQfqLWq PYww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=AjG90qv/twC3NNitx5G27f0PcvYD7lxKo6hJNUT2X7Q=; b=PSGNmxmGTFc0QP2XLsl2aImhEHE91ThhxXA2heNVZD/U0G2s8TkAsQtGM7/LUwll0Z 7nocOnIA4Z5rCK29DzVJzlN3yFaSCy1WZvzqYEkIpihjfGScQMKO2V93i0/gOl1YJcj0 xq/9t/3rDSq4UJlkhswGy65hI6tG+KeJifnfix+uqlpaQnPDd7wnKw6moDGTIK6rJD5+ KrZ9eKDp9uaJo8FREWzM+T7KP9EY0He+UhxNK6nszdW1PrVSXJA/XdGO8S3dZbohY4Gs FGkbDSWdrU8UPyRxtE/aBeSrF+thsoF+we9xOvjUJEzSOg3ZOJbyFZQ+Qd4qJXr4dCwC k82Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="RojfUt/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si9569632eje.347.2021.03.09.10.58.39; Tue, 09 Mar 2021 10:59:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b="RojfUt/l"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230288AbhCIS5n (ORCPT + 99 others); Tue, 9 Mar 2021 13:57:43 -0500 Received: from m42-2.mailgun.net ([69.72.42.2]:59053 "EHLO m42-2.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230525AbhCIS5K (ORCPT ); Tue, 9 Mar 2021 13:57:10 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1615316230; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=AjG90qv/twC3NNitx5G27f0PcvYD7lxKo6hJNUT2X7Q=; b=RojfUt/lB5mJwiJHz2pgSDlP68QY/z430EkB5g/pN8sZPkk0CDgWs+KHwmscRIqz8LDhfN+k ffJ9C1LY3DDQTwWazG8KHuxLTHp0Z245erKf5zhWvdfyl/0+SketnXJkI/fAlWVlALDs4euo X+SpN/MIvUX8BK9DCcDSXYKBF6o= X-Mailgun-Sending-Ip: 69.72.42.2 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-east-1.postgun.com with SMTP id 6047c4faaf1d9a68adf7bfa2 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 09 Mar 2021 18:56:58 GMT Sender: jhugo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 0F81AC43463; Tue, 9 Mar 2021 18:56:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL autolearn=no autolearn_force=no version=3.4.0 Received: from [10.226.59.216] (i-global254.qualcomm.com [199.106.103.254]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: jhugo) by smtp.codeaurora.org (Postfix) with ESMTPSA id D238EC433CA; Tue, 9 Mar 2021 18:56:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D238EC433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=jhugo@codeaurora.org Subject: Re: [PATCH v3] bus: mhi: core: Add missing checks for MMIO register entries To: Bhaumik Bhatt , manivannan.sadhasivam@linaro.org Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, linux-kernel@vger.kernel.org, carl.yin@quectel.com, naveen.kumar@quectel.com, loic.poulain@linaro.org References: <1615315490-36017-1-git-send-email-bbhatt@codeaurora.org> From: Jeffrey Hugo Message-ID: Date: Tue, 9 Mar 2021 11:56:56 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <1615315490-36017-1-git-send-email-bbhatt@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/9/2021 11:44 AM, Bhaumik Bhatt wrote: > As per documentation, fields marked as (required) in an MHI > controller structure need to be populated by the controller driver > before calling mhi_register_controller(). Ensure all required > pointers and non-zero fields are present in the controller before > proceeding with the registration. > > Signed-off-by: Bhaumik Bhatt > --- Reviewed-by: Jeffrey Hugo -- Jeffrey Hugo Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.