Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] arm64: dts: imx8mq: remove SoC ID compatible
To:     Martin Kepplinger <martin.kepplinger@puri.sm>,
        alice.guo@oss.nxp.com
Cc:     devicetree@vger.kernel.org, festevam@gmail.com,
        kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
        linux-imx@nxp.com, linux-kernel@vger.kernel.org, robh@kernel.org,
        s.hauer@pengutronix.de, shawnguo@kernel.org
References: <20210104091544.13972-4-alice.guo@oss.nxp.com>
 <20210309134251.2583679-1-martin.kepplinger@puri.sm>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Message-ID: <d2030810-a307-0438-d4b0-be6aa092e551@kernel.org>
Date:   Tue, 9 Mar 2021 21:56:30 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.1
MIME-Version: 1.0
In-Reply-To: <20210309134251.2583679-1-martin.kepplinger@puri.sm>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 09/03/2021 14:42, Martin Kepplinger wrote:
> this reverts commit ce58459d8c7f4174e7b8a8ea903dd949631334a3 for imx8mq.
> 
> this is most likely not the real fix but works around the problem I have
> (with v5.12-rc2) I want to report:
> 
> [    0.766925] SoC revision 0x21
> [    0.770286] imx8_soc_info soc@0: SoC revision via nvmem read failed: -517
> 
> This leads to the system not booting up.
> 
> This change makes use of the old way of reading soc_revision and thus
> works around the problem.
> 
> What could be missing for the nvmem way to work here? Should it work
> in any case? I assume so if you add the compatible to imx8mq.dtsi. But
> if it would work, why keep the ocotp reads?

Hi,

Thanks for the report. 517 is deferred probe, so this could mean that
efuse/ocotp did not come up yet. However soc_id driver should handle it
and re-try after some try, shouldn't it? Unless there is a bug inside
(your change basically disables soc_id driver).

Best regards,
Krzysztof