Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Tue, 09 Mar 2021 23:59:58 +0100
From:   Michael Walle <michael@walle.cc>
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     devicetree@vger.kernel.org, NXP Linux Team <linux-imx@nxp.com>,
        Fabio Estevam <festevam@gmail.com>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Shawn Guo <shawnguo@kernel.org>,
        Tudor Ambarus <tudor.ambarus@microchip.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Richard Weinberger <richard@nod.at>,
        linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: at25: add Fujitsu MB85RS4MT
In-Reply-To: <20210309220014.22205-1-tharvey@gateworks.com>
References: <20210309220014.22205-1-tharvey@gateworks.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <8ca5c54140d69307f3c08ca85a09f0b5@walle.cc>
Precedence: bulk

Hi Tim,

Am 2021-03-09 23:00, schrieb Tim Harvey:
> Document the compatible value for the Fujitsu MB85RS4MT SPI
> FRAM EEPROM device so that it can be used in DTS files.
> 
> This is a 512KiB FRAM EEPROM.
> 
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  Documentation/devicetree/bindings/eeprom/at25.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/eeprom/at25.yaml
> b/Documentation/devicetree/bindings/eeprom/at25.yaml
> index 6a2dc8b3ed14..f594db72b711 100644
> --- a/Documentation/devicetree/bindings/eeprom/at25.yaml
> +++ b/Documentation/devicetree/bindings/eeprom/at25.yaml
> @@ -26,6 +26,7 @@ properties:
>                - anvo,anv32e61w
>                - atmel,at25256B
>                - fujitsu,mb85rs1mt
> +              - fujitsu,mb85rs4mt
>                - fujitsu,mb85rs64
>                - microchip,at25160bn
>                - microchip,25lc040

Hm, the driver is spi-nor but this is for the at25 driver. Is
this correct? Doesn't it work if you just add the ID to
spi-nor/fujitsu.c and use 'compatible = "jedec,spi-nor' ?

-michael