Received: by 2002:a05:6a10:8c0a:0:0:0:0 with SMTP id go10csp38674pxb; Tue, 9 Mar 2021 15:10:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJycxOFO2t5H4t8haRNxeOexcGsBW8IbI8ldLr7N6Pz2WJbBspzNzixCgUDazIy32ylaiYVW X-Received: by 2002:a17:906:3488:: with SMTP id g8mr439166ejb.282.1615331441471; Tue, 09 Mar 2021 15:10:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615331441; cv=none; d=google.com; s=arc-20160816; b=su2O6gOzuihzIFF62OZpFfmovTiqnxhq5ucOZk9Q3oDWpwin+do/1oPhf743Oua6vo tXchMr1rhdBfdkXQJc96jWMROEbJrlDn9S7tEcq8wmV+AV0tFg/kVZp1jWg+bur+ADBN z7SfeBm7SPkHWSlSpp/c1/S/2ZaloQ7yB4qwkfxzSPxKxRNCUKK3z8hybgWFlm1yYPUO mzHKBrCo3NEw5tlGj1gDfFjWUzwkiC0KrqSafVoZAAd5CMQZ7mZq4MFQWVrUmsaQ2KGi B/xVlxJilNrdVesKiqrKIkJSDHhO7L8FgJN9ZEiVws8xkxLpDzILrRmyC902IegmqUVV EcUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:autocrypt:from :references:cc:to:subject:ironport-sdr:ironport-sdr; bh=P/8bf2qIABj0tjRLDe6VBwt16oRAsJ7hiujF5bobdEI=; b=bWn2hEuAxJQQp0Widq8xk2QRAmNi2Wv1Yqai5YSOhNKBsbaNZgv1cbXsUg5jAx7MSe 2jNP4fdb6bu4jv4NMA29WuHlKl+vFmFkKyfJFSQkGWsxUzZDgqBC+6c8K0vkbirq03ms 9W24Nc8bbyWNMAflI40QXRikpYvtxJTIz+0yxDUPOuBW0Vi/RHrn3dxlcnHNnYbhvJ5w PtjBdlqw/tQ7x8n5aA/4f2GerSXhzPZbQaYb3b9zb7UghOAUiYLnC1LZQvAlgqlo2p5i WCpnZxga8fTvKIYs/rALxEj+UFsNtccwusN94dup75BNkr/WBysDG+3H6L+87dKs4/4j blew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id fx21si10190752ejb.91.2021.03.09.15.10.17; Tue, 09 Mar 2021 15:10:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232082AbhCIXGU (ORCPT + 99 others); Tue, 9 Mar 2021 18:06:20 -0500 Received: from mga07.intel.com ([134.134.136.100]:13056 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230320AbhCIXF6 (ORCPT ); Tue, 9 Mar 2021 18:05:58 -0500 IronPort-SDR: 5akqdT2r1k1281rqWU8xNB6G7H6GqELws19PkEmSVGHoktIVgyWlIdGu4PHo1U5Q7zfqYwy291 oJvgwT3EKrnw== X-IronPort-AV: E=McAfee;i="6000,8403,9917"; a="252358775" X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="252358775" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 15:05:58 -0800 IronPort-SDR: bS/gu01g7Rr0wwtKvGnwED0wTKFyiX6e+XXRI5v3j23PdJR8TRPnG2irkQsNsU9JzSa8oGJOFV eOgeMM1oRzCA== X-IronPort-AV: E=Sophos;i="5.81,236,1610438400"; d="scan'208";a="447679644" Received: from jcchan4-mobl.amr.corp.intel.com (HELO [10.212.217.30]) ([10.212.217.30]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Mar 2021 15:05:57 -0800 Subject: Re: [PATCH 05/10] mm/migrate: demote pages during reclaim To: Yang Shi , Dave Hansen Cc: Linux Kernel Mailing List , Linux MM , Yang Shi , David Rientjes , Huang Ying , Dan Williams , Oscar Salvador References: <20210304235949.7922C1C3@viggo.jf.intel.com> <20210304235958.ECFA81E5@viggo.jf.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzShEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gPGRhdmVAc3I3MS5uZXQ+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJ CgsEFgIDAQIeAQIXgAUCTo3k0QIZAQAKCRBoNZUwcMmSsMO2D/421Xg8pimb9mPzM5N7khT0 2MCnaGssU1T59YPE25kYdx2HntwdO0JA27Wn9xx5zYijOe6B21ufrvsyv42auCO85+oFJWfE K2R/IpLle09GDx5tcEmMAHX6KSxpHmGuJmUPibHVbfep2aCh9lKaDqQR07gXXWK5/yU1Dx0r VVFRaHTasp9fZ9AmY4K9/BSA3VkQ8v3OrxNty3OdsrmTTzO91YszpdbjjEFZK53zXy6tUD2d e1i0kBBS6NLAAsqEtneplz88T/v7MpLmpY30N9gQU3QyRC50jJ7LU9RazMjUQY1WohVsR56d ORqFxS8ChhyJs7BI34vQusYHDTp6PnZHUppb9WIzjeWlC7Jc8lSBDlEWodmqQQgp5+6AfhTD kDv1a+W5+ncq+Uo63WHRiCPuyt4di4/0zo28RVcjtzlGBZtmz2EIC3vUfmoZbO/Gn6EKbYAn rzz3iU/JWV8DwQ+sZSGu0HmvYMt6t5SmqWQo/hyHtA7uF5Wxtu1lCgolSQw4t49ZuOyOnQi5 f8R3nE7lpVCSF1TT+h8kMvFPv3VG7KunyjHr3sEptYxQs4VRxqeirSuyBv1TyxT+LdTm6j4a mulOWf+YtFRAgIYyyN5YOepDEBv4LUM8Tz98lZiNMlFyRMNrsLV6Pv6SxhrMxbT6TNVS5D+6 UorTLotDZKp5+M7BTQRUY85qARAAsgMW71BIXRgxjYNCYQ3Xs8k3TfAvQRbHccky50h99TUY sqdULbsb3KhmY29raw1bgmyM0a4DGS1YKN7qazCDsdQlxIJp9t2YYdBKXVRzPCCsfWe1dK/q 66UVhRPP8EGZ4CmFYuPTxqGY+dGRInxCeap/xzbKdvmPm01Iw3YFjAE4PQ4hTMr/H76KoDbD cq62U50oKC83ca/PRRh2QqEqACvIH4BR7jueAZSPEDnzwxvVgzyeuhwqHY05QRK/wsKuhq7s UuYtmN92Fasbxbw2tbVLZfoidklikvZAmotg0dwcFTjSRGEg0Gr3p/xBzJWNavFZZ95Rj7Et db0lCt0HDSY5q4GMR+SrFbH+jzUY/ZqfGdZCBqo0cdPPp58krVgtIGR+ja2Mkva6ah94/oQN lnCOw3udS+Eb/aRcM6detZr7XOngvxsWolBrhwTQFT9D2NH6ryAuvKd6yyAFt3/e7r+HHtkU kOy27D7IpjngqP+b4EumELI/NxPgIqT69PQmo9IZaI/oRaKorYnDaZrMXViqDrFdD37XELwQ gmLoSm2VfbOYY7fap/AhPOgOYOSqg3/Nxcapv71yoBzRRxOc4FxmZ65mn+q3rEM27yRztBW9 AnCKIc66T2i92HqXCw6AgoBJRjBkI3QnEkPgohQkZdAb8o9WGVKpfmZKbYBo4pEAEQEAAcLB XwQYAQIACQUCVGPOagIbDAAKCRBoNZUwcMmSsJeCEACCh7P/aaOLKWQxcnw47p4phIVR6pVL e4IEdR7Jf7ZL00s3vKSNT+nRqdl1ugJx9Ymsp8kXKMk9GSfmZpuMQB9c6io1qZc6nW/3TtvK pNGz7KPPtaDzvKA4S5tfrWPnDr7n15AU5vsIZvgMjU42gkbemkjJwP0B1RkifIK60yQqAAlT YZ14P0dIPdIPIlfEPiAWcg5BtLQU4Wg3cNQdpWrCJ1E3m/RIlXy/2Y3YOVVohfSy+4kvvYU3 lXUdPb04UPw4VWwjcVZPg7cgR7Izion61bGHqVqURgSALt2yvHl7cr68NYoFkzbNsGsye9ft M9ozM23JSgMkRylPSXTeh5JIK9pz2+etco3AfLCKtaRVysjvpysukmWMTrx8QnI5Nn5MOlJj 1Ov4/50JY9pXzgIDVSrgy6LYSMc4vKZ3QfCY7ipLRORyalFDF3j5AGCMRENJjHPD6O7bl3Xo 4DzMID+8eucbXxKiNEbs21IqBZbbKdY1GkcEGTE7AnkA3Y6YB7I/j9mQ3hCgm5muJuhM/2Fr OPsw5tV/LmQ5GXH0JQ/TZXWygyRFyyI2FqNTx4WHqUn3yFj8rwTAU1tluRUYyeLy0ayUlKBH ybj0N71vWO936MqP6haFERzuPAIpxj2ezwu0xb1GjTk4ynna6h5GjnKgdfOWoRtoWndMZxbA z5cecg== Message-ID: <71db9a12-f81e-a341-b3ab-bf66d3c1ab39@intel.com> Date: Tue, 9 Mar 2021 15:05:57 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/8/21 4:10 PM, Yang Shi wrote: >> +static struct page *alloc_demote_page(struct page *page, unsigned long node) >> +{ >> + struct migration_target_control mtc = { >> + /* >> + * Fail the allocation quickly and quietly. When this >> + * happens, 'page; will likely just be discarded instead >> + * of migrated. >> + */ >> + .gfp_mask = GFP_HIGHUSER_MOVABLE | __GFP_NORETRY | __GFP_NOWARN, >> + .nid = node > I recall I pointed out __GFP_THISNODE should be needed to guarantee > the allocation doesn't fallback. But it seems it is not solved yet or > it is guaranteed by the other way? Sorry about missing that before. This mask definitely needs __GFP_THISNODE. I've added it for the next version.