Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] block: rsxx: fix error return code of rsxx_pci_probe()
To:     Jens Axboe <axboe@kernel.dk>, josh.h.morris@us.ibm.com,
        pjk1939@linux.ibm.com
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20210308100554.10375-1-baijiaju1990@gmail.com>
 <cf2dd66c-0e1e-944e-f4c5-542095f6c9d7@kernel.dk>
From:   Jia-Ju Bai <baijiaju1990@gmail.com>
Message-ID: <0a0a6160-f469-9be8-a9e2-3067c02f0b57@gmail.com>
Date:   Wed, 10 Mar 2021 09:13:43 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.4.1
MIME-Version: 1.0
In-Reply-To: <cf2dd66c-0e1e-944e-f4c5-542095f6c9d7@kernel.dk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 2021/3/10 4:59, Jens Axboe wrote:
> On 3/8/21 3:05 AM, Jia-Ju Bai wrote:
>> Some error handling segments of rsxx_pci_probe() do not return error code,
>> so add error code for these segments.
>>
>> Fixes: 8722ff8cdbfa ("block: IBM RamSan 70/80 device driver")
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
>> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
>> ---
>>   drivers/block/rsxx/core.c | 18 +++++++++++++++---
>>   1 file changed, 15 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
>> index 63f549889f87..6b3b9b31a3e8 100644
>> --- a/drivers/block/rsxx/core.c
>> +++ b/drivers/block/rsxx/core.c
>> @@ -760,13 +760,17 @@ static int rsxx_pci_probe(struct pci_dev *dev,
>>   	pci_set_drvdata(dev, card);
>>   
>>   	st = ida_alloc(&rsxx_disk_ida, GFP_KERNEL);
>> -	if (st < 0)
>> +	if (st < 0) {
>> +		st = -ENOMEM;
>>   		goto failed_ida_get;
>> +	}
>>   	card->disk_id = st;
>>   
>>   	st = pci_enable_device(dev);
>> -	if (st)
>> +	if (st) {
>> +		st = -EIO;
>>   		goto failed_enable;
>> +	}
>>   
>>   	pci_set_master(dev);
> Maybe there are some valid parts to the patch, but the two above at
> least make no sense - we're returning the error here as passed from
> ida_alloc or pci_enable_device, why are you overriding them?
>

Ah, sorry for these incorrect parts...
I will send a new patch.


Best wishes,
Jia-Ju Bai