Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1615294733-22761-1-git-send-email-aisheng.dong@nxp.com>
 <1615294733-22761-5-git-send-email-aisheng.dong@nxp.com> <b6de03c9-8744-90b2-11fe-914ef016fa1f@gmail.com>
In-Reply-To: <b6de03c9-8744-90b2-11fe-914ef016fa1f@gmail.com>
From:   Dong Aisheng <dongas86@gmail.com>
Date:   Wed, 10 Mar 2021 10:42:23 +0800
Message-ID: <CAA+hA=RbvKSyeLVdJBiqnKwGVJQBzKLJi1z68BHoKHeypjQKCQ@mail.gmail.com>
Subject: Re: [PATCH 04/11] PM / devfreq: bail out early if no freq changes in devfreq_set_target
To:     Chanwoo Choi <cwchoi00@gmail.com>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Linux PM <linux-pm@vger.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        Sascha Hauer <kernel@pengutronix.de>,
        Shawn Guo <shawnguo@kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>,
        open list <linux-kernel@vger.kernel.org>,
        myungjoo.ham@samsung.com, kyungmin.park@samsung.com,
        Chanwoo Choi <cw00.choi@samsung.com>,
        Abel Vesa <abel.vesa@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Tue, Mar 9, 2021 at 11:47 PM Chanwoo Choi <cwchoi00@gmail.com> wrote:
>
> On 21. 3. 9. =EC=98=A4=ED=9B=84 9:58, Dong Aisheng wrote:
> > It's unnecessary to set the same freq again and run notifier calls.
> >
> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > ---
> >   drivers/devfreq/devfreq.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> > index bf3047896e41..6e80bf70e7b3 100644
> > --- a/drivers/devfreq/devfreq.c
> > +++ b/drivers/devfreq/devfreq.c
> > @@ -358,6 +358,9 @@ static int devfreq_set_target(struct devfreq *devfr=
eq, unsigned long new_freq,
> >       else
> >               cur_freq =3D devfreq->previous_freq;
> >
> > +     if (new_freq =3D=3D cur_freq)
> > +             return 0;
> > +
> >       freqs.old =3D cur_freq;
> >       freqs.new =3D new_freq;
> >       devfreq_notify_transition(devfreq, &freqs, DEVFREQ_PRECHANGE);
> > @@ -374,7 +377,7 @@ static int devfreq_set_target(struct devfreq *devfr=
eq, unsigned long new_freq,
> >        * and DEVFREQ_POSTCHANGE because for showing the correct frequen=
cy
> >        * change order of between devfreq device and passive devfreq dev=
ice.
> >        */
> > -     if (trace_devfreq_frequency_enabled() && new_freq !=3D cur_freq)
> > +     if (trace_devfreq_frequency_enabled())
> >               trace_devfreq_frequency(devfreq, new_freq, cur_freq);
> >
> >       freqs.new =3D new_freq;
> >
>
> I'd like you to squash patch4 with patch6 because actually patch6
> is too minor clean-up. I think it is possible.

Got it, will squash when re-send.

Regards
Aisheng

>
> --
> Best Regards,
> Samsung Electronics
> Chanwoo Choi