Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp60669pxf; Tue, 9 Mar 2021 23:52:08 -0800 (PST) X-Google-Smtp-Source: ABdhPJzs6jszgeKrzqI7yr8Xwx0RUCE7dOxrjOGw4ozyDfrf+PjCqKYrpESf/Ahwpogk7oX1N/BD X-Received: by 2002:a17:906:789:: with SMTP id l9mr2233552ejc.161.1615362728493; Tue, 09 Mar 2021 23:52:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615362728; cv=none; d=google.com; s=arc-20160816; b=p4lJR9Ot4+ONI1xL6i7spWM17WDXCDQnxCQ7H0lCFkvCKwjHP6uMklXmXPyvz2UpeB WOjnrTLNbt/8WepTTlGTz48uTKnKy1vPa9F+io7KQPf8cspBy1OUuW2Rsih66JAl2Apj qNBsh4pt8/tp9ykQDee/XeXkIVY9jEfGAgzz35bxnEEYN1nSIZOVO2t/tBrQ6Tj0rTAH qHazvBJijyqu0z3Uga1tPOJM5se1jpQCM0BJoaODI9RY0W/vdk+2rFldIaqb3EDGnLCd Z0qtx49by0YgqNzxUTMu2Me2w4S2Nc+02I0yDNuqRhiTcN8fnqP7y3hL31xEbMtDI/55 azHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=E3GUwDl0fv/Pd3Xv3artfLoSybGcF/CmtQfDxts61hs=; b=tUsTMII3HxaHQ2FSxIPE4KQ/WfFqNSsujrRgXd7OEoQrHX7rg/H9h9rzl5QRstDvcG clAngKTNK1aBRksI4ocNmtGNv5ocbhX5F57GTIqvyLy4ySMX1QHpFtc8SnzELllgFiid nGzujJf26BXSR2Bi5sqeX2CBLQNAZnPTA4Z5cCwovNyZmmgFE9pP/KTlNMpNy8ORzhK9 Qo1AGzcf1F2Ip55aHuBC0GrqK5cg+cmqEAcpKJWwHWWG0sgTcMZFNLH5r8BlSSBV/Sg5 1zioIlMbUeXwbCBRGcXnV4UKuGfkmfcxSUf2G6c4W+byt31WMzUSWzAUVwk7kCLtrFS0 mVkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=XoOh7apv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n3si11401601edq.382.2021.03.09.23.51.46; Tue, 09 Mar 2021 23:52:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=XoOh7apv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232349AbhCJHuN (ORCPT + 99 others); Wed, 10 Mar 2021 02:50:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57590 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232376AbhCJHty (ORCPT ); Wed, 10 Mar 2021 02:49:54 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83312C06174A; Tue, 9 Mar 2021 23:49:54 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1A4BBF3; Wed, 10 Mar 2021 08:49:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1615362592; bh=YgKt8m7oB1wqNJ5FwJ0SwR0cY4QWuOoPNs+HQQGJ21M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XoOh7apvvgLBbsYv7nd3ObReGqgEfdY4JGntBf/MNpkAWeZOPhfo3BIAjmhHO2+eW jrgf4mOiniZHrl2+UbEtcsGSeZb7VM9gfqb/nabFcYfjJikp+fArrglk0VtWuwkY6N 9Whu7B1gGJ1tiS/+FW1TIofsIbpN6T5WmKpPynx4= Date: Wed, 10 Mar 2021 09:49:20 +0200 From: Laurent Pinchart To: Ricardo Ribalda Cc: Tomasz Figa , Marek Szyprowski , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] media: videobuf2: Fix integer overrun in allocation Message-ID: References: <20210309234317.1021588-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210309234317.1021588-1-ribalda@chromium.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ricardo, Thank you for the patch. On Wed, Mar 10, 2021 at 12:43:17AM +0100, Ricardo Ribalda wrote: > The plane_length is an unsigned integer. So, if we have a size of > 0xffffffff bytes we incorrectly allocate 0 bytes instead of 1 << 32. > > Cc: stable@vger.kernel.org > Fixes: 7f8414594e47 ("[media] media: videobuf2: fix the length check for mmap") > Signed-off-by: Ricardo Ribalda > --- > drivers/media/common/videobuf2/videobuf2-core.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/common/videobuf2/videobuf2-core.c b/drivers/media/common/videobuf2/videobuf2-core.c > index 02281d13505f..543da515c761 100644 > --- a/drivers/media/common/videobuf2/videobuf2-core.c > +++ b/drivers/media/common/videobuf2/videobuf2-core.c > @@ -223,8 +223,10 @@ static int __vb2_buf_mem_alloc(struct vb2_buffer *vb) > * NOTE: mmapped areas should be page aligned > */ > for (plane = 0; plane < vb->num_planes; ++plane) { > + unsigned long size = vb->planes[plane].length; unsigned long is still 32-bit on 32-bit platforms. > + > /* Memops alloc requires size to be page aligned. */ > - unsigned long size = PAGE_ALIGN(vb->planes[plane].length); > + size = PAGE_ALIGN(size); > > /* Did it wrap around? */ > if (size < vb->planes[plane].length) Doesn't this address the issue already ? -- Regards, Laurent Pinchart