Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp86967pxf; Wed, 10 Mar 2021 00:49:55 -0800 (PST) X-Google-Smtp-Source: ABdhPJxBbDRO0JoivULTsFNUI+Ri1ZTPoL48jF406w1KTMaAJJN6f2fUn8K6WRE5Q1k8i/MBEAjz X-Received: by 2002:a17:906:ae88:: with SMTP id md8mr2414715ejb.264.1615366195703; Wed, 10 Mar 2021 00:49:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615366195; cv=none; d=google.com; s=arc-20160816; b=HaR8z5voOXRkHojAIIrpnbnK1cO3bi89Dh4GIVDfw5lkg2COYAeeWwPOVFTrsuqHUX 7kdfBd74md5juPnOLVjhfgkTzsmz0ElWWLDbRC+oTI4ku5qOiOeO8h1cQw7DTTdU8r9B 4d+MbeGCa7ZF4DNjPIL7HYrHF3v6Bknzl4u4vOYF2lcLp5bApH8UIm8EQUL/pWkvvMnv j4pUIgEzJFhT0Ex+3UDsdeNUReSjDZk98RZDEvVUjRukOqRa1/VlzYwcwIBCAUog/si+ 5B2BJNjNwXWU7eOCOfki9nb/DuKnGzo8bpn0fJn3MKj13VAzx1ysI5Rz5mne1hRF1jQe +D+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=r3Bn+zVYcqguLSTpzwfRHKLjhZswbybmdP/hWNnvaE4=; b=b6t3CS+MXr3qBOkC74sr92OH5jIYa2p5NOMB5Cwdk0cR43aPa6eZul4b8se5/F5RwV V2CFRcp0biDyI/VEH9e/2j9cm6pmIgQX5Q5iaj6H7hWWWJoWEKC1rkrFLDIYSdVQyilc DvK1ASprsVNgRC7QQqOUH3zdOxo7SvHjKSJHDSbGjKh1kTjDBxYKi07XUzvUrgbVQQLK sKoalltgKN+fm3TcOy+TT8bxA/PUOWHCGHMUCGY6IwMdt3mYFmUJy3qVyNWkjsMLOkp/ 1ZxRkrpMNjgw2eNipiUUcvcp8PZ51OW0Op1wp8UpYEiy6xNi9n3oeUnPgc/VmjDGv7Ya 2dyQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v14si10866710ejj.133.2021.03.10.00.49.33; Wed, 10 Mar 2021 00:49:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229559AbhCJIqh (ORCPT + 99 others); Wed, 10 Mar 2021 03:46:37 -0500 Received: from out30-45.freemail.mail.aliyun.com ([115.124.30.45]:49045 "EHLO out30-45.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbhCJIqH (ORCPT ); Wed, 10 Mar 2021 03:46:07 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R301e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04400;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0URFMdXP_1615365964; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0URFMdXP_1615365964) by smtp.aliyun-inc.com(127.0.0.1); Wed, 10 Mar 2021 16:46:05 +0800 From: Yang Li To: arnd@arndb.de Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, Yang Li Subject: [PATCH] char/mwave: turn tp3780I_InitializeBoardData() into void function Date: Wed, 10 Mar 2021 16:46:03 +0800 Message-Id: <1615365963-2096-1-git-send-email-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: ./drivers/char/mwave/tp3780i.c:182:5-11: Unneeded variable: "retval". Return "0" on line 187 Reported-by: Abaci Robot Signed-off-by: Yang Li --- drivers/char/mwave/tp3780i.c | 6 +----- drivers/char/mwave/tp3780i.h | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/char/mwave/tp3780i.c b/drivers/char/mwave/tp3780i.c index 5e1618a..8588b51 100644 --- a/drivers/char/mwave/tp3780i.c +++ b/drivers/char/mwave/tp3780i.c @@ -177,14 +177,10 @@ int tp3780I_InitializeBoardData(THINKPAD_BD_DATA * pBDData) return retval; } -int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData) +void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData) { - int retval = 0; - PRINTK_2(TRACE_TP3780I, "tp3780i::tp3780I_Cleanup entry and exit pBDData %p\n", pBDData); - - return retval; } int tp3780I_CalcResources(THINKPAD_BD_DATA * pBDData) diff --git a/drivers/char/mwave/tp3780i.h b/drivers/char/mwave/tp3780i.h index 07685b6..8bd976d 100644 --- a/drivers/char/mwave/tp3780i.h +++ b/drivers/char/mwave/tp3780i.h @@ -91,7 +91,7 @@ int tp3780I_ResetDSP(THINKPAD_BD_DATA * pBDData); int tp3780I_StartDSP(THINKPAD_BD_DATA * pBDData); int tp3780I_QueryAbilities(THINKPAD_BD_DATA * pBDData, MW_ABILITIES * pAbilities); -int tp3780I_Cleanup(THINKPAD_BD_DATA * pBDData); +void tp3780I_Cleanup(THINKPAD_BD_DATA *pBDData); int tp3780I_ReadWriteDspDStore(THINKPAD_BD_DATA * pBDData, unsigned int uOpcode, void __user *pvBuffer, unsigned int uCount, unsigned long ulDSPAddr); -- 1.8.3.1