Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Thomas Gleixner <tglx@linutronix.de>
To:     Oleg Nesterov <oleg@redhat.com>
Cc:     Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH] signal: Allow RT tasks to cache one sigqueue struct
In-Reply-To: <draft-874khk5yed.fsf@nanos.tec.linutronix.de>
References: <draft-874khk5yed.fsf@nanos.tec.linutronix.de>
Date:   Wed, 10 Mar 2021 09:57:30 +0100
Message-ID: <87v99z4c91.fsf@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain
Precedence: bulk

On Tue, Mar 09 2021 at 13:01, Thomas Gleixner wrote:
> On Fri, Mar 05 2021 at 11:57, Oleg Nesterov wrote:
>> On 03/04, Thomas Gleixner wrote:
>>> On Wed, Mar 03 2021 at 16:37, Oleg Nesterov wrote:
>>> >> +static bool sigqueue_add_cache(struct task_struct *t, struct sigqueue *q)
>>> >> +{
>>> >> +	if (!t->sigqueue_cache && cmpxchg(&t->sigqueue_cache, NULL, q) == NULL)
>>> >> +		return true;
>>> >> +	return false;
>>> >> +}
>>> >
>>> > Do we really need cmpxchg? It seems they are always called with
>>> > spinlock held.
>>>
>>> With which spinlock held?
>>>
>>> __send_signal()         <- sighand::siglock held
>>>   __sigqueue_alloc()
>>>
>>> alloc_posix_timer()
>>>   sigqueue_alloc()      <- No lock held
>>>     __sigqueue_alloc()
>>
>> In the last case "fromslab" is true, sigqueue_from_cache() won't be called.
>>
>>> and on the free side we have a bunch of callers which do not hold
>>> sighand::siglock either.
>>
>> Where?

Bah. I confused myself. Let me start over with that.

Thanks,

        tglx