Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH V2 1/2] dt-bindings: nvmem: add Broadcom's NVRAM
To:     =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <zajec5@gmail.com>,
        Rob Herring <robh+dt@kernel.org>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mips@vger.kernel.org,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vivek Unune <npcomplete13@gmail.com>,
        bcm-kernel-feedback-list@broadcom.com,
        linux-kernel@vger.kernel.org,
        =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= <rafal@milecki.pl>
References: <20210305183236.11784-1-zajec5@gmail.com>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <4be3e736-8bd5-b9e4-9c5b-e69b164e152d@linaro.org>
Date:   Wed, 10 Mar 2021 10:23:36 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.8.0
MIME-Version: 1.0
In-Reply-To: <20210305183236.11784-1-zajec5@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 05/03/2021 18:32, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Broadcom's NVRAM structure contains device data and can be accessed
> using I/O mapping.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---


Applied both patches!


thanks
-srini

> V2: Use Broadcom's NVRAM specific binding. Generic "nvmem-iomap" binding
>      didn't make much sense. Thanks Srinivas!
> ---
>   .../devicetree/bindings/nvmem/brcm,nvram.yaml | 34 +++++++++++++++++++
>   1 file changed, 34 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> 
> diff --git a/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> new file mode 100644
> index 000000000000..58ff6b0bdb1a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/nvmem/brcm,nvram.yaml
> @@ -0,0 +1,34 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/nvmem/brcm,nvram.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom's NVRAM
> +
> +description: |
> +  Broadcom's NVRAM is a structure containing device specific environment
> +  variables. It is used for storing device configuration, booting parameters
> +  and calibration data.
> +
> +  NVRAM can be accessed on Broadcom BCM47xx MIPS and Northstar ARM Cortex-A9
> +  devices usiong I/O mapped memory.
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +allOf:
> +  - $ref: "nvmem.yaml#"
> +
> +properties:
> +  compatible:
> +    const: brcm,nvram
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    nvram@1eff0000 {
> +            compatible = "brcm,nvram";
> +            reg = <0x1eff0000 0x10000>;
> +    };
>