Received: by 2002:a05:6a10:9848:0:0:0:0 with SMTP id x8csp240363pxf; Wed, 10 Mar 2021 05:26:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJwBMGr/nbCDKY2e1+kr+M3mEsoevvCX1Q+vFPQymGryCZ++8bYvBUVoQAu2qwsPMq+LaMHX X-Received: by 2002:a05:6402:c11:: with SMTP id co17mr3361225edb.246.1615382787642; Wed, 10 Mar 2021 05:26:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615382787; cv=none; d=google.com; s=arc-20160816; b=nkdVV7RL1nz/ku04pj+JX2Hb97RNtWhkqkCj02e7u6k15soALJj73tIzEXEEQlWBT5 pGwjjep7EKw1ZP62QIeP0/DB0IOBCkMg+h/ZlOpZYVvI/aUHTuwNGc70sM+hPoc9HgdF 9o3uED+j3BUqCcQG+eLrNtA4v7B8SDJpq2E79Zuw+/5eJVZQIA8o2CMBNrbNR4XN0rxm FqTN22k3L1WbjnDUNjb9EaBvZOlqmyz+UR//sCmNzJVg8Y7eh4Db+SS3DUWuurmmHfnP iZ7p5Oc0T/c6KMSQVDEq7Qd97Xha/j4F0wuySbE5Gz1EWW+vto73taYc3WNlSDGVFxlR EY2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GCoieMGJtLei7zy4tX4QKuf7LEUaFTrgXPOjVrAxBjI=; b=t3nDSwMZS1jn81t6C7deQsHBHclIHZoXHgP95Zex9Ra4dkaq1VauALIqyLIX/0UC6Y hjnmzNLi9i0XtMaQVJGr91Z7z8c0zK3RgjMXInudIa3/v44kjpgx8kkvLtPgXPe7vAJR /jGJyG+D0JcDcyv3oasbm9SJq3ZoywzUcdKmiqyqKX+a9xjitx9w5G5HsZXvIFr+XD8J R2S1mcJDsiTSZ+kSWmwJpT4qG7HPikq5w7MhkHuko8BtlnHqaRQCsPM2AvmoLfF+sEf3 fyJFO4u9V3kbZfYzx+K0p/6szp8fH1/QoxHhPdQfELAzYZlxjNmSscHPAD5qLfgwuu7I 8K8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MBGHOrPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id rs13si12003133ejb.31.2021.03.10.05.26.02; Wed, 10 Mar 2021 05:26:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=MBGHOrPh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233075AbhCJNYv (ORCPT + 99 others); Wed, 10 Mar 2021 08:24:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:45430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230477AbhCJNYM (ORCPT ); Wed, 10 Mar 2021 08:24:12 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7904264FDA; Wed, 10 Mar 2021 13:24:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1615382652; bh=1ysddjLBcxrlM6JytO6CiDqg1Z4JwWvCFkYzUsce+wM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MBGHOrPhyPlK65ZGSG8juGpX1Wq2gDIQHq22lyg+CUjI9b2DMMKekBjvQSP7y70PW Cp01uGovh0gHugvH8ehhe21AKw2aKS09HvGQBp3Bl5OqX0OvK4TDlF+5petlRF84w2 voYlucZNbGcKrMqxN2jL6kB/p1eL8Y6Kca3uByZE= From: gregkh@linuxfoundation.org To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?UTF-8?q?Zolt=C3=A1n=20B=C3=B6sz=C3=B6rm=C3=A9nyi?= , Christoph Hellwig , Sudip Mukherjee Subject: [PATCH 5.10 03/49] nvme-pci: mark Kingston SKC2000 as not supporting the deepest power state Date: Wed, 10 Mar 2021 14:23:14 +0100 Message-Id: <20210310132322.065236469@linuxfoundation.org> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210310132321.948258062@linuxfoundation.org> References: <20210310132321.948258062@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Greg Kroah-Hartman From: "Zolt?n B?sz?rm?nyi" commit dc22c1c058b5c4fe967a20589e36f029ee42a706 upstream My 2TB SKC2000 showed the exact same symptoms that were provided in 538e4a8c57 ("nvme-pci: avoid the deepest sleep state on Kingston A2000 SSDs"), i.e. a complete NVME lockup that needed cold boot to get it back. According to some sources, the A2000 is simply a rebadged SKC2000 with a slightly optimized firmware. Adding the SKC2000 PCI ID to the quirk list with the same workaround as the A2000 made my laptop survive a 5 hours long Yocto bootstrap buildfest which reliably triggered the SSD lockup previously. Signed-off-by: Zoltán Böszörményi Signed-off-by: Christoph Hellwig [sudip: adjust context] Signed-off-by: Sudip Mukherjee Signed-off-by: Greg Kroah-Hartman --- drivers/nvme/host/pci.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/nvme/host/pci.c +++ b/drivers/nvme/host/pci.c @@ -3264,6 +3264,8 @@ static const struct pci_device_id nvme_i .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, { PCI_DEVICE(0x15b7, 0x2001), /* Sandisk Skyhawk */ .driver_data = NVME_QUIRK_DISABLE_WRITE_ZEROES, }, + { PCI_DEVICE(0x2646, 0x2262), /* KINGSTON SKC2000 NVMe SSD */ + .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, { PCI_DEVICE(0x2646, 0x2263), /* KINGSTON A2000 NVMe SSD */ .driver_data = NVME_QUIRK_NO_DEEPEST_PS, }, { PCI_DEVICE(PCI_VENDOR_ID_APPLE, 0x2001),